Fix: Anju rando item gives failing when performing an action#3107
Merged
leggettc18 merged 1 commit intoHarbourMasters:develop-sulufrom Aug 12, 2023
Merged
Conversation
garrettjoecox
approved these changes
Aug 7, 2023
leggettc18
approved these changes
Aug 12, 2023
Contributor
|
Same here, criteria is now met |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous fix to Anju for adult rando item gives (#1766) introduced a bug where the GiveItem calls were only executed once, which meant if the player performed any action that blocks an GiveItem for the frame (shielding, pulling out any items, etc), the item would not be given on the next frame as the code path for Anju has finished.
This PR restores the desired code paths, matching what the vanilla item gives do, while maintaining that the correct flags are set in rando.
There were todo statements that weren't clear why they were there, so I removed them as the item gives now match the same behavior as the rest of the code base in my opinion.
Build Artifacts