Fix: Showing pocket cucco in rando gives first Anju reward instead#1766
Merged
briaguya0 merged 1 commit intoHarbourMasters:develop-zhorafrom Oct 13, 2022
Merged
Conversation
briaguya0
approved these changes
Oct 13, 2022
leggettc18
approved these changes
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1415.
In vanilla, the flags
gSaveContext.itemGetInf[2] & 0x1000andgSaveContext.itemGetInf[2] & 0x4000are used to determine what Anju says when spoken to, and the former is also used to determine whether she gives you the pocket cucco or Cojiro.This fix makes it so that in randomizer, the item given is independent of
gSaveContext.itemGetInf[2] & 0x1000. Additionally, whereas before they were set after Link was given the item, rando now sets them at the same time the item Link gets is determined so that the correct flag is set for the location checked.