Skip to content

Adds tooltip function and tooltips to various ImGui menu items#306

Merged
NEstelami merged 16 commits intoHarbourMasters:developfrom
GreatArgorath:ImGuiTooltips
May 14, 2022
Merged

Adds tooltip function and tooltips to various ImGui menu items#306
NEstelami merged 16 commits intoHarbourMasters:developfrom
GreatArgorath:ImGuiTooltips

Conversation

@GreatArgorath
Copy link
Member

2022-05-12.20-26-31.mp4

Adding new tooltips for new menu items is as simple as Tooltip("tooltiptexthere"); below any menu item you want a tooltip on

@jbodner09
Copy link
Contributor

jbodner09 commented May 13, 2022

Tooltips for line 628-631 would also be super helpful to explain what the numbers translate to (can't comment directly there since Github doesn't allow comments on collapsed lines...)

EnhancementSliderInt("Internal Resolution: %dx", "##IMul", "gInternalResolution", 1, 8, "");
gfx_current_dimensions.internal_mul = CVar_GetS32("gInternalResolution", 1);
EnhancementSliderInt("MSAA: %d", "##IMSAA", "gMSAAValue", 1, 8, "");
gfx_msaa_level = CVar_GetS32("gMSAAValue", 1);

@jbodner09
Copy link
Contributor

Same with all the enhancements on lines 742-748 and maybe all the debug settings too.

EnhancementCheckbox("No Clip", "gNoClip");
EnhancementCheckbox("Climb Everything", "gClimbEverything");
EnhancementCheckbox("Moon Jump on L", "gMoonJumpOnL");
EnhancementCheckbox("Super Tunic", "gSuperTunic");
EnhancementCheckbox("Easy ISG", "gEzISG");
EnhancementCheckbox("Unrestricted Items", "gNoRestrictItems");
EnhancementCheckbox("Freeze Time", "gFreezeTime");

Adds for anti-aliasing settings, cheats, and debug settings
Changes tooltip for input scale to be more clear
Copy link
Contributor

@NEstelami NEstelami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merge pending rebase conflict resolution.

@NEstelami NEstelami merged commit 247360c into HarbourMasters:develop May 14, 2022
Kenix3 pushed a commit that referenced this pull request Jun 17, 2022
* Add Controller Navigation

- Apply Rainbow patch
- Add Controller Navigation
- Controller "Back" button opens F1 Menu
- Controller Rumble/Gyro settings at the bottom of the controller menu

* Restore changes from PR #306

Add back update from #306

* Add Tooltip of new functionality

Tooltip: 
Allows controller navigation of the menu bar
D-pad to move between items, A to select, and X to grab focus on the menu bar

* set & save check

* Fixes for switch port
th-2021 pushed a commit to th-2021/Shipwright-cmake that referenced this pull request Jun 19, 2022
* Add Controller Navigation

- Apply Rainbow patch
- Add Controller Navigation
- Controller "Back" button opens F1 Menu
- Controller Rumble/Gyro settings at the bottom of the controller menu

* Restore changes from PR HarbourMasters#306

Add back update from HarbourMasters#306

* Add Tooltip of new functionality

Tooltip: 
Allows controller navigation of the menu bar
D-pad to move between items, A to select, and X to grab focus on the menu bar

* set & save check

* Fixes for switch port
stratomaster64 pushed a commit to stratomaster64/Shipwright that referenced this pull request Jun 20, 2022
* Add Controller Navigation

- Apply Rainbow patch
- Add Controller Navigation
- Controller "Back" button opens F1 Menu
- Controller Rumble/Gyro settings at the bottom of the controller menu

* Restore changes from PR HarbourMasters#306

Add back update from HarbourMasters#306

* Add Tooltip of new functionality

Tooltip: 
Allows controller navigation of the menu bar
D-pad to move between items, A to select, and X to grab focus on the menu bar

* set & save check

* Fixes for switch port
aMannus pushed a commit to aMannus/Shipwright that referenced this pull request Jul 7, 2022
…-skip

Zora's River Waterfall Cutscene Skip
Kenix3 pushed a commit to Kenix3/Shipwright that referenced this pull request Oct 19, 2022
…urMasters#306)

* Adds tooltip function and tooltips to various ImGui menu items

* Update SohImGuiImpl.cpp

* Adds more tooltips and changes input scale tooltip

Adds for anti-aliasing settings, cheats, and debug settings
Changes tooltip for input scale to be more clear

* Fixes typos, makes N64 mode more clear, and americanizes it

* Update SohImGuiImpl.cpp

* Standardises D-pad spelling

* Update SohImGuiImpl.cpp

* Fixes typo, changes dungeon entrances tooltip, and fixes tabs

* Clearer wording

* Removes full stop

* Removes spaces from new line

* Removes space after \n

* Makes Linux compile

* Fixes wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants