Skip to content

Adds toggle for build info on N64 logo screen#255

Closed
GreatArgorath wants to merge 12 commits intoHarbourMasters:developfrom
GreatArgorath:buildinfo
Closed

Adds toggle for build info on N64 logo screen#255
GreatArgorath wants to merge 12 commits intoHarbourMasters:developfrom
GreatArgorath:buildinfo

Conversation

@GreatArgorath
Copy link
Member

2022-05-01.20-31-09.online-video-cutter.com.mp4

Pretty self explanatory, most don't need to know this and it looks a bit cluttered, so it should be toggleable.

@MegaMech
Copy link
Contributor

MegaMech commented May 7, 2022

I think the button text should be renamed to: "SoH Splash Screen" (or similar) it's more clear and less characters.

Developer Tools is not a good location for this button. I think it should go under enhancements.

Technically, this isn't the title screen. I recommend renaming your variables as well.

@PurpleHato
Copy link
Member

I think the button text should be renamed to: "SoH Splash Screen" (or similar) it's more clear and less characters.

Developer Tools is not a good location for this button. I think it should go under enhancements.

Technically, this isn't the title screen. I recommend renaming your variables as well.

I agree with the renaming, but moving it to Enhancement, I don't think m, It's not an enhancement in any way and it's related to the Dev itself, I think it should stay there

@MegaMech
Copy link
Contributor

MegaMech commented May 7, 2022

It's not related to the developer tools tab in anyway. It does not belong in there. This screen is for normal users to help them keep track of what version they are using. It's not a development tool. It even has fun splash text.

@GreatArgorath
Copy link
Member Author

Got it, I was naming it based on the file names, as all of this is done in the title file, and my brain couldn't think of the right name for it at the time.

I'll rename it and move it to enhancements.

@Kenix3
Copy link
Collaborator

Kenix3 commented Jun 8, 2022

I'm skeptical that this needs to be in the enhancements menu. We're already proliferating the menu with a ton of options. Anyone have any thoughts?

@MelonSpeedruns
Copy link
Contributor

I don't think we should disable our only in-game way to show credits and the build version. However, feel free to discuss it with us afterwards on Discord.

aMannus pushed a commit to aMannus/Shipwright that referenced this pull request Jul 2, 2022
@GreatArgorath GreatArgorath deleted the buildinfo branch July 14, 2022 09:34
Malkierian pushed a commit to Malkierian/Shipwright that referenced this pull request Nov 20, 2023
Co-authored-by: briaguya <briaguya@alice>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants