Fix: add missing rando settings values that weren't being parsed on save creation#2541
Merged
briaguya0 merged 1 commit intoHarbourMasters:developfrom Feb 27, 2023
Merged
Conversation
dcvz
approved these changes
Feb 26, 2023
briaguya0
pushed a commit
to briaguya0/Shipwright
that referenced
this pull request
Feb 27, 2023
briaguya0
added a commit
that referenced
this pull request
Feb 28, 2023
* fix RSK parsing error introduced by #2541 * add logic to not give greg hint when we shouldn't --------- Co-authored-by: briaguya <briaguya@alice>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all rando settings were being parsed from the spoiler log as they weren't being used in game. But now with the check tracker, sometimes we need to know settings values to display/hide checks.
This adds all missing settings values that could be parsed.
The 100GS token in 3ds settings was marked as a toggle and using no/yes instead of off/on, updated so it parses correctly
The only ones I didn't touch were ganon trial setting and mq dungeon since thats not being saved into the spoiler log (skip/random/count). This is fine since the actual parts that matter are stored elsewhere in the save context.
Build Artifacts