Fix dungeon entrance icon + feature#252
Conversation
|
Is it still possible to have the original broken behavior after this change? Specifically the unnecessary top left icon behavior, I can't seem to reproduce that any more. Toggling Fixing/unfixing the other icon positions by toggling the CVar works normally. EDIT: I think this might be a mistake: Shipwright/soh/src/code/z_map_exp.c Line 773 in 065291d That first condition is where the bug fix happens, and that's evaluated regardless of whether the user has the bugfix CVar set, so it's no longer possible for the bugged behavior to occur regardless of CVar setting. I think you'd want to do something more like this, where the bug fix condition only occurs if the CVar is set. if (CVar_GetS32("gFixDungeonMinimapIcon", 0) != 0 ? gMapData->owEntranceIconPosY[sEntranceIconMapIndex] << 2 != 0 : 1 ) {The ternary I'm using here will just return Fixing that exposes a new problem, though. In the original bug, the dungeon entrance icon appeared at the top-left origin, whereas now the bugged Hyrule Field dungeon icon appears in a different location:
I think this is something to do with the margin adjustments introduced to align the icon with the right side of the screen, but my understanding of how those changes work is poor. EDIT2: Also, once any further bugs with the bug (haha) are fixed, this should probably go back to being defaulted off like all the other fixes, per @Kenix3's statement on Discord. |
…t-skip Skip ruto text box in jabu blue warp
* Add Cvar stuff and fix dungeon entrance icons * Added Cvar toggles * Move fixes to fix sub menu
This PR add Fixes submenu to include L&R Kaleido button color and this Dungeon icon on minimap. (under Enhancements menu)
It fixes the Dungeon Entrance icon that was not visible when it should be and was present when it should not.
Also it add the ability to show the dungeon entrance before finishing a dungeon.
This code also rework a bit the icon draw to make it a bit more readable.
Screen before fixes:
Screenshots after fixes:
Here what the fix look next to GCN version
