Bosses title cards fixes#247
Merged
Kenix3 merged 25 commits intoHarbourMasters:developfrom May 2, 2022
Merged
Conversation
Contributor
Author
|
I converted it to draft to prevent a merge before I am done, |
funny how that the horse that hold the title card.
imagine in TitleCard_InitBossName setting isBossCard to false...
Contributor
Author
|
reworked the code itself and should be a clean one if anyone has a better idea how to make it better feel free |
Kenix3
approved these changes
May 2, 2022
aMannus
pushed a commit
to aMannus/Shipwright
that referenced
this pull request
Jul 2, 2022
Added flags for ruto falling down hole
Kenix3
pushed a commit
to Kenix3/Shipwright
that referenced
this pull request
Oct 19, 2022
* Boss title fixes. * Proper X/Y/H/W * Proper x,y,w,h * Proper X,Y,W,H * Actually had wrong height (was 32, should be 40) * one of the last x,y,h,w fix * WIP really need a better way to check it. * Fix Ganondorf title card. * better conditional logic * No more workaround! * Add two var in the TitleCardContext structures * Added hasTranslation to Phantom Ganon's Horse funny how that the horse that hold the title card. * Add hasTranslation to Dodongo. * Revert workaround and add hasTranslation=false * Added hasTranslation to big piggy Ganon * Add hasTranslation to Gohma * Add hasTranslation to Morpha * Add hasTranslation to Twins first part. * Add hastranslation to that eletro "dude" * Add hastranslation to bongo bongo * Added hasTranslation to airwing v2 * add hasTranslation to TitleCard_InitBossName init * isBossCard to true now that I can confirm it work imagine in TitleCard_InitBossName setting isBossCard to false... * no need to use bool there is seem to not like it * change bool to s16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, Ganondorf I hate you why do you have to play bad like that?
This PR is to fix Germand and French title cards translation
(except Ganondorf, for some reasons this one do not have translation.)
Every bosses has been tested and quite a lot of zone name.
now when you use TitleCard_InitBossName you can tell if there is a translation or not.
This need method I think that a clean one. :)
Btw in TitleCard_InitBossName() in bosses files I use true/false for better readability and in code it translate to 0/1
so that fine :)