Skip to content

[WIP] Translate Korean and Hebrew body content from English#1101

Merged
pethers merged 1 commit intomasterfrom
copilot/translate-korean-hebrew-files
Mar 6, 2026
Merged

[WIP] Translate Korean and Hebrew body content from English#1101
pethers merged 1 commit intomasterfrom
copilot/translate-korean-hebrew-files

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 5, 2026

  • Fix index_ko.html tabindex inconsistency (add tabindex="-1" to nav links: 서비스, 제품, 블로그, FAQ, 연락처)
  • Translate 21 Korean blog articles (English body → Korean)
  • Translate 34 Korean discordian ISMS files (English body → Korean)
  • Translate Korean blog listing page (blog_ko.html)
  • Translate Korean ISO/industry files (1 remaining)
  • Translate 20 Hebrew blog articles (English body → Hebrew RTL)
  • Translate 31 Hebrew discordian ISMS files (English body → Hebrew RTL)
  • Run code review and security checks
Original prompt

This section details on the original issue you should resolve

<issue_title>[Translation] Korean (KO) & Hebrew (HE) - Translate English body content (~55 KO / ~50 HE files)</issue_title>
<issue_description>## 🎯 Objective
Translate body content in ~55 Korean (_ko) and ~50 Hebrew (_he) HTML files that currently contain English text despite having localized metadata and navigation.

📋 Background

Korean and Hebrew are critical for Hack23's Asian and Middle Eastern market presence. Both languages have ~50-57% of files with English body content. Hebrew additionally requires correct RTL (right-to-left) handling.

Korean (KO) breakdown:

Category Files with English body Total
Blog articles 18/27 67%
Discordian ISMS 30/43 70%
Product pages 3/10 30%
Industry + ISO 4/7 57%
Core pages 0/5 0% ✅
Total 55/96 57%

Hebrew (HE) breakdown:

Category Files with English body Total
Blog articles 17/27 63%
Discordian ISMS 30/43 70%
Product pages 3/10 30%
Industry + ISO 0/7 0% ✅
Core pages 0/5 0% ✅
Total 50/96 52%

Good news: Both languages have their core pages and most product pages already translated. The primary gap is in blog posts and discordian ISMS policy articles.

Known Korean issue (from repository memory): index_ko.html has inconsistent tabindex="-1" on nav links — only the first two links have it while the remaining links do not. This should also be fixed.

✅ Acceptance Criteria

  • All 18 Korean blog articles translated with Korean body content
  • All 30 Korean discordian ISMS files translated with Korean body content
  • Remaining 4 Korean industry/ISO files translated
  • Remaining 3 Korean product files translated
  • All 17 Hebrew blog articles translated with Hebrew body content
  • All 30 Hebrew discordian ISMS files translated with Hebrew body content
  • Remaining 3 Hebrew product files translated
  • Korean uses proper Hangul characters throughout (no romanization of Korean terms)
  • Hebrew uses proper RTL text direction and correct nikud where needed
  • Hebrew files maintain dir="rtl" attribute where appropriate
  • Korean index_ko.html tabindex inconsistency fixed (all nav links should have tabindex="-1")
  • HTML structure, links, images, and metadata remain intact

🛠️ Implementation Guidance

Priority order:

  1. Product pages (3 KO + 3 HE = 6 files) — finish remaining product translations
  2. Industry/ISO pages (4 KO = 4 files) — complete Korean industry pages
  3. Blog articles (18 KO + 17 HE = 35 files) — translate article body content
  4. Discordian ISMS (30 KO + 30 HE = 60 files) — translate policy article bodies
  5. Fix KO tabindex — add tabindex="-1" to remaining nav links in index_ko.html

Approach:

  1. Translate <article>/<main> body content from English to Korean/Hebrew
  2. For Korean: Use formal/professional register (합니다/습니다 endings)
  3. For Hebrew: Ensure RTL text direction is maintained; use formal register
  4. Keep HTML tags, attributes, links, images intact
  5. Use index_ko.html / index_he.html as terminology reference
  6. Cybersecurity terms: use standard Korean (사이버보안) / Hebrew (אבטחת סייבר) equivalents

🤖 Recommended Agent

Agent: @ui-enhancement-specialist
Rationale: This task involves HTML content translation with special requirements for Korean character encoding and Hebrew RTL support.

For implementation:

  • Translate body content to professional Korean and Hebrew
  • Maintain RTL layout integrity for Hebrew files
  • Fix Korean nav link tabindex accessibility issue
  • Preserve HTML structure, ARIA attributes, and semantic markup</issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 5, 2026

@pethers pethers merged commit 7305617 into master Mar 6, 2026
10 of 12 checks passed
Copilot stopped work on behalf of pethers due to an error March 6, 2026 00:35
@pethers pethers deleted the copilot/translate-korean-hebrew-files branch March 6, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Translation] Korean (KO) & Hebrew (HE) - Translate English body content (~55 KO / ~50 HE files)

2 participants