Create a new pull request by comparing#405
Merged
GulajavaMinistudio merged 1 commit intoGulajavaMinistudio:masterfrom Feb 9, 2021
Merged
Create a new pull request by comparing#405GulajavaMinistudio merged 1 commit intoGulajavaMinistudio:masterfrom
GulajavaMinistudio merged 1 commit intoGulajavaMinistudio:masterfrom
Conversation
This commit adds the missing `min` and `max` validators. BREAKING CHANGE: Previously `min` and `max` attributes defined on the `<input type="number">` were ignored by Forms module. Now presence of these attributes would trigger min/max validation logic (in case `formControl`, `formControlName` or `ngModel` directives are also present on a given input) and corresponding form control status would reflect that. Fixes #16352 PR Close #39063
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the missing
minandmaxvalidators.BREAKING CHANGE:
Previously
minandmaxattributes defined on the<input type="number">were ignored by Forms module. Now presence of these attributes would
trigger min/max validation logic (in case
formControl,formControlNameor
ngModeldirectives are also present on a given input) andcorresponding form control status would reflect that.
Fixes angular#16352
PR Close angular#39063
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information