feat(forms): introduce min and max validators by sonukapoor · Pull Request #39063 · angular/angular

sonukapoor · 2020-09-30T16:26:20Z

This commit adds the missing min and max validators.

BREAKING CHANGE:

Previously min and max attributes defined on the <input type="number">
were ignored by Forms module. Now presence of these attributes would
trigger min/max validation logic (in case formControl, formControlName
or ngModel directives are also present on a given input) and
corresponding form control status would reflect that.

Fixes #16352

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

Does this PR introduce a breaking change?

Yes
No

AndrewKushnir · 2020-10-01T02:17:27Z

Initial presubmit to see if it breaks targets in g3 (+ global presubmit as well).

packages/forms/src/directives/validators.ts

sonukapoor · 2021-02-04T15:11:26Z

@AndrewKushnir Thanks for the updated information. The changes and the refactor of the unit tests look good to me.

jessicajaniuk

reviewed-for: public-api

packages/forms/src/directives/validators.ts

goldens/public-api/forms/forms.d.ts

This commit adds the missing `min` and `max` validators. BREAKING CHANGE: Previously `min` and `max` attributes defined on the `<input type="number">` were ignored by Forms module. Now presence of these attributes would trigger min/max validation logic (in case `formControl`, `formControlName` or `ngModel` directives are also present on a given input) and corresponding form control status would reflect that. Fixes angular#16352

mary-poppins · 2021-02-05T00:57:30Z

You can preview 76d699b at https://pr39063-76d699b.ngbuilds.io/.

AndrewKushnir · 2021-02-05T00:58:33Z

Thanks for the review @atscott, great catch on string vs string|number type! 👍

I've pushed a fixup commit to adjust types. Could you please have another look when you get a chance?

AndrewKushnir · 2021-02-05T03:22:31Z

FYI, also started a new Global Presubmit.

atscott

reviewed-for: public-api

AndrewKushnir · 2021-02-05T18:44:16Z

The feedback was addressed and the most recent TGP run is successful, so I'm adding this PR to the merge queue.

@sonukapoor huge thanks for working on this feature and addressing all the comments 👍
Also thanks to the reviewers for provided feedback!

AndrewKushnir · 2021-02-05T18:46:19Z

Note to Caretaker: this PR is ready for merge, the TGP is "green" (only one unrelated build failure). It'd still be great to sync it in g3 as a separate/individual change to rollback easier if needed. Thank you.

sonukapoor · 2021-02-05T19:55:24Z

Always a pleasure @AndrewKushnir

Airblader · 2021-03-13T15:32:34Z

Does this affect applications which specify both the attribute and separately a corresponding validator in any way? Or would the validator then just run twice without noticable effects?

AndrewKushnir · 2021-03-13T19:13:12Z

@Airblader this change adds new min/max validators that would be invoked on <input type="number"> (when min/max attributes are present). This change does not block other existing (custom) validators from being executed.

angular-automatic-lock-bot · 2021-04-13T16:08:57Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Sep 30, 2020

sonukapoor force-pushed the min_max_validators branch 2 times, most recently from fe44e5e to 6fea537 Compare October 1, 2020 01:54

AndrewKushnir added area: forms state: WIP labels Oct 1, 2020

ngbot bot added this to the needsTriage milestone Oct 1, 2020

AndrewKushnir added target: major This PR is targeted for the next major release action: presubmit The PR is in need of a google3 presubmit labels Oct 1, 2020

sonukapoor force-pushed the min_max_validators branch 2 times, most recently from 3492716 to 971cf8d Compare October 1, 2020 12:30

sonukapoor marked this pull request as ready for review October 1, 2020 12:31

pullapprove bot requested a review from AndrewKushnir October 1, 2020 12:31

sonukapoor force-pushed the min_max_validators branch 3 times, most recently from c16413b to 354c930 Compare October 2, 2020 13:37

AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Nov 4, 2020

AndrewKushnir mentioned this pull request Dec 21, 2020

Support for .invalid operator in html to validate html min/max value #40216

Closed

sonukapoor force-pushed the min_max_validators branch 8 times, most recently from 6fea895 to c9fde70 Compare December 30, 2020 18:34

petebacondarwin reviewed Dec 31, 2020

View reviewed changes

packages/forms/src/directives/validators.ts Outdated Show resolved Hide resolved

petebacondarwin reviewed Dec 31, 2020

View reviewed changes

packages/forms/src/directives/validators.ts Outdated Show resolved Hide resolved

sonukapoor force-pushed the min_max_validators branch 2 times, most recently from b8ddaff to 9540729 Compare December 31, 2020 16:55

AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Feb 4, 2021

jessicajaniuk approved these changes Feb 4, 2021

View reviewed changes

atscott reviewed Feb 4, 2021

View reviewed changes

packages/forms/src/directives/validators.ts Outdated Show resolved Hide resolved

goldens/public-api/forms/forms.d.ts Outdated Show resolved Hide resolved

sonukapoor and others added 3 commits February 4, 2021 16:47

fixup! feat(forms): introduce min and max validators

1e03920

fixup! feat(forms): introduce min and max validators

76d699b

AndrewKushnir force-pushed the min_max_validators branch from 49c77c0 to 76d699b Compare February 5, 2021 00:49

AndrewKushnir requested review from atscott and removed request for alxhub February 5, 2021 00:58

AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Feb 5, 2021

atscott approved these changes Feb 5, 2021

View reviewed changes

AndrewKushnir removed the request for review from jelbourn February 5, 2021 18:39

AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: presubmit The PR is in need of a google3 presubmit labels Feb 5, 2021

alxhub closed this in 8fb83ea Feb 8, 2021

This was referenced Feb 9, 2021

Create a new pull request by comparing GulajavaMinistudio/angular#405

Merged

Create a new pull request by comparing TypescriptID/angular#600

Merged

sonukapoor deleted the min_max_validators branch February 19, 2021 03:23

angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 13, 2021

Conversation

sonukapoor commented Sep 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

Does this PR introduce a breaking change?

Uh oh!

AndrewKushnir commented Oct 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonukapoor commented Feb 4, 2021

Uh oh!

jessicajaniuk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mary-poppins commented Feb 5, 2021

Uh oh!

AndrewKushnir commented Feb 5, 2021

Uh oh!

AndrewKushnir commented Feb 5, 2021

Uh oh!

atscott left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir commented Feb 5, 2021

Uh oh!

AndrewKushnir commented Feb 5, 2021

Uh oh!

sonukapoor commented Feb 5, 2021

Uh oh!

Airblader commented Mar 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndrewKushnir commented Mar 13, 2021

Uh oh!

angular-automatic-lock-bot bot commented Apr 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

sonukapoor commented Sep 30, 2020 •

edited

Loading

AndrewKushnir commented Oct 1, 2020 •

edited

Loading

Airblader commented Mar 13, 2021 •

edited

Loading