ci: set CC and CXX to force compiler used in setuptools / distutils#1995
Merged
romanc merged 10 commits intoGridTools:mainfrom Apr 23, 2025
Merged
ci: set CC and CXX to force compiler used in setuptools / distutils#1995romanc merged 10 commits intoGridTools:mainfrom
CC and CXX to force compiler used in setuptools / distutils#1995romanc merged 10 commits intoGridTools:mainfrom
Conversation
let's see if it also occurrs in case we use the frozen uv.lock file
CC and CXX to force compiler used in setuptools / distutils
Contributor
Author
|
/cc @FlorianDeconinck FYI what I was blabbering on yesterday in standup |
havogt
approved these changes
Apr 23, 2025
Contributor
havogt
left a comment
There was a problem hiding this comment.
Thanks for investigating!
Contributor
Author
Always happy to help :) |
2 tasks
stubbiali
pushed a commit
to stubbiali/gt4py
that referenced
this pull request
Aug 19, 2025
…utils` (GridTools#1995) ## Description `gt4py.cartesian` uses `setuptools` / `distutils` to compiler sources. For some unknown reason, the default compiler changed in the GHA runners over the last weekend. Daily CI started to fail as a consequence. This PR forces the GNU compiler suite by setting `CC` and `CXX` environment variable to `gcc` and `g++` respectively. While `setuptools` version 75 is happy with just `CXX`, the oldest supported `setuptools` version (70) also requires setting `CC` in order not to mix the (apparent new default) `clang` compiler with `g++` as `C` and `C++` compilers respectively. From reading - pypa/setuptools#1732 - pypa/distutils#228 (scroll all the way down to get to comments as recent as 2024) setting compilers is a bit fragile and subject to active discussions/development. Tested by also running the "Daily CI" job temporarily on this PR. ## Requirements - [ ] All fixes and/or new features come with corresponding tests. N/A - [ ] Important design decisions have been documented in the appropriate ADR inside the [docs/development/ADRs/](docs/development/ADRs/README.md) folder. N/A --------- Co-authored-by: Roman Cattaneo <1116746+romanc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
gt4py.cartesianusessetuptools/distutilsto compiler sources. For some unknown reason, the default compiler changed in the GHA runners over the last weekend. Daily CI started to fail as a consequence. This PR forces the GNU compiler suite by settingCCandCXXenvironment variable togccandg++respectively.While
setuptoolsversion 75 is happy with justCXX, the oldest supportedsetuptoolsversion (70) also requires settingCCin order not to mix the (apparent new default)clangcompiler withg++asCandC++compilers respectively. From readingsetting compilers is a bit fragile and subject to active discussions/development.
Tested by also running the "Daily CI" job temporarily on this PR.
Requirements