Skip to content

Use protected superclass fields via super because of GROOVY-9292#655

Merged
johnrengelman merged 1 commit intoGradleUp:masterfrom
m8nmueller:master
Mar 30, 2021
Merged

Use protected superclass fields via super because of GROOVY-9292#655
johnrengelman merged 1 commit intoGradleUp:masterfrom
m8nmueller:master

Conversation

@m8nmueller
Copy link
Copy Markdown
Contributor

The use of the abstract fields in the ServiceFileTransformer without super results in an error in newer Groovy versions since PR 1050. For the current Gradle 7.0 RC, that looks like this:

Caused by: groovy.lang.MissingPropertyException: No such property: count for class: com.github.jengelman.gradle.plugins.shadow.transformers.ServiceFileTransformer
        at com.github.jengelman.gradle.plugins.shadow.transformers.ServiceFileTransformer$ServiceStream.append(ServiceFileTransformer.groovy:110)
        at ...

Apart from that, the plugin is usable with Gradle 7.0, as far as I can tell.

@johnrengelman johnrengelman added this to the 6.2 milestone Mar 30, 2021
@johnrengelman johnrengelman merged commit 37fcc73 into GradleUp:master Mar 30, 2021
@breskeby
Copy link
Copy Markdown

Any concrete plans for the 6.2 release?

@johnrengelman
Copy link
Copy Markdown
Collaborator

Working on it now Rene.

breskeby added a commit to breskeby/elasticsearch that referenced this pull request Apr 26, 2021
This fixes a gradle 7.0 incompatibility with the shadow plugin 6.1
see GradleUp/shadow#655 for details
@breskeby
Copy link
Copy Markdown

breskeby commented Apr 26, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants