Fixes to allow Configuration Caching in Gradle 6.6+#591
Merged
johnrengelman merged 6 commits intoGradleUp:masterfrom Oct 5, 2020
Merged
Fixes to allow Configuration Caching in Gradle 6.6+#591johnrengelman merged 6 commits intoGradleUp:masterfrom
johnrengelman merged 6 commits intoGradleUp:masterfrom
Conversation
We (myself and @britter) believe this PR allows the Shadow Plugin to be used in a Gradle 6.6+ build with --configuration-cache enabled. We unfortunately did not get round to fixing the case where `minimize()` is used, so it does not work if that is called in the build. We're basically looking for suggestions on what we can do to improve it, or whether it is good enough to go in as-is Cheers Tim (and Benedikt)
Author
|
(upcoming configuration cache feature is described here https://docs.gradle.org/release-candidate/userguide/configuration_cache.html) |
Contributor
|
@eskatos I think you only need to call def "configuration caching supports minimize"() {
given:
buildFile << """
shadowJar {
minimize()
}
""".stripIndent()
when:
runner.withArguments('--configuration-cache', 'shadowJar').build()
output.delete()
def result = runner.withArguments('--configuration-cache', 'shadowJar').build()
then:
contains(output, ['a.properties', 'b.properties'])
and:
doesNotContain(output, ['a2.properties'])
result.output.contains("Reusing configuration cache.")
} |
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
1cc82aa to
a45502d
Compare
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Contributor
|
With the latest changes above, the Here are some links about configuration caching in Gradle:
@johnrengelman this should be ready for review, could you please take a look? BTW it looks like the circleci build is broken |
eskatos
added a commit
to eskatos/jmh-gradle-plugin
that referenced
this pull request
Sep 21, 2020
vlsi
reviewed
Oct 7, 2020
| jar.inputs.property('mainClassName', classNameProvider) | ||
| jar.doFirst { | ||
| manifest.attributes 'Main-Class': pluginConvention.mainClassName | ||
| manifest.attributes 'Main-Class': classNameProvider.get() |
Contributor
There was a problem hiding this comment.
manifest.attributes support providers: https://twitter.com/VladimirSitnikv/status/1260952932981313544
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We (myself and @britter) believe this PR allows the Shadow Plugin to be used
in a Gradle 6.6+ build with --configuration-cache enabled.
We unfortunately did not get round to fixing the case where
minimize()isused, so it does not work if that is called in the build.
We're basically looking for suggestions on what we can do to improve it,
or whether it is good enough to go in as-is
Cheers
Tim (and Benedikt)