Avoid UnusedTracker creation when minimizeJar is not requested#480
Merged
johnrengelman merged 1 commit intoGradleUp:masterfrom Jun 29, 2019
sormuras:no-minimize-no-tracker
Merged
Avoid UnusedTracker creation when minimizeJar is not requested#480johnrengelman merged 1 commit intoGradleUp:masterfrom sormuras:no-minimize-no-tracker
johnrengelman merged 1 commit intoGradleUp:masterfrom
sormuras:no-minimize-no-tracker
Conversation
marcphilipp
approved these changes
Apr 3, 2019
Contributor
Author
|
Ping @johnrengelman ... any plans to include this PR or implement some other measure to help with |
Contributor
|
@johnrengelman Any chance of getting this merged? We currently have to use a fork of the plugin in junit5. https://github.com/junit-team/junit5/blob/02417272bb22b8c710a0f58bc98505a49ef82107/settings.gradle.kts#L15 |
Contributor
Author
|
Any news? |
|
@johnrengelman Please merge this. |
Contributor
Author
|
Yeah, would be great to get rid of this work-around junit-team/junit-framework@c4a2a7b |
sormuras
added a commit
to junit-team/junit-framework
that referenced
this pull request
Jun 29, 2019
Still using jitpack until the new 5.x version is released. GradleUp/shadow#480
Contributor
Author
|
Thanks for merging, @johnrengelman! Already updated our Gradle configuration to your latest |
sormuras
added a commit
to junit-team/junit-framework
that referenced
this pull request
Jun 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #479