Change names of files with the same path - this time by Transformer#102
Change names of files with the same path - this time by Transformer#102amorfis wants to merge 5 commits intoGradleUp:mainfrom
Conversation
…it can use it to modify output stream.
…t is used, both files are in final jar but with changed filename.
|
Hello, |
There was a problem hiding this comment.
Won't mergedJar.name work fine for this? Seems like we've made a bunch of changes that aren't really need as the information is available from the existing API.
There was a problem hiding this comment.
On that note, I'd prefer if you kept the changes to a minimum. The variable renames makes this a lot harder to review because it's harder to see what the actually change was.
There was a problem hiding this comment.
Ok, thanks for looking at this! WRT variables naming, I was really lost with "archive", it was never clear to me if it is the .jar we are merging into fat jar, or far jar itself.
WRT redundancy, I'll look at this, but AFAIR there was no jar file path in mergedJar
There was a problem hiding this comment.
There was a problem hiding this comment.
I'd prefer to name the variable sourceJar then.
|
Hi, I was trying to restore the possibility to filter-out files from certain jars, a feature that was supported in the past (according to the old readme, but I never tested it): I tried to implement this using a Transformer, but I think that this PR is required, because the transformer API does not have any information about the path or the name of the jar which the file comes from... |
The shadowJar plugin makes a single file out of all the dependencies of our services. Occasionally, this leads to file conflicts. Jackson's META-INF/LICENSE conflicts with the directory META-INF/license While we can run the shadowJars, you cannot extract them with `jar -x`, as it ends up with an IOException extracting META-INF/license. This excludes Jackson's META-INF/LICENSE, until we have a better solution, ideally with one of the proposals in the shadow jar project. See GradleUp/shadow#86 See GradleUp/shadow#102
|
Looks this should be handled by |
Hello,
What about this one? ;)