Skip to content

Support double click on layer panel drag handle to reset height#717

Merged
wassgha merged 1 commit intolayer-panelfrom
add/layer-dblclick
Mar 24, 2020
Merged

Support double click on layer panel drag handle to reset height#717
wassgha merged 1 commit intolayer-panelfrom
add/layer-dblclick

Conversation

@swissspidy
Copy link
Copy Markdown
Collaborator

See #704

@swissspidy swissspidy added the Type: Enhancement New feature or improvement of an existing feature label Mar 23, 2020
@swissspidy swissspidy requested a review from wassgha March 23, 2020 14:19
@github-actions
Copy link
Copy Markdown
Contributor

Size Change: +44 B (0%)

Total Size: 432 kB

Filename Size Change
assets/js/edit-story.js 369 kB +44 B (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 241 B 0 B
assets/css/stories-dashboard.css 206 B 0 B
assets/js/stories-dashboard.js 63.2 kB 0 B

compressed-size-action

Copy link
Copy Markdown
Contributor

@barklund barklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes good sense. Should there be a keyboard shortcut to do the same thing? Pressing backspace when focused or something like that? Don't really know what would make sense here.

@wassgha wassgha merged commit 2dd4877 into layer-panel Mar 24, 2020
@wassgha wassgha deleted the add/layer-dblclick branch March 24, 2020 00:02
wassgha added a commit that referenced this pull request Mar 27, 2020
* Adapt initial layer panel height to layer numbers

* Support double click on layer panel drag handle to reset height (#717)

* Added maximum initial layer number to show

* Rethink collapse/expand logic

* Fixed issue that broke tests

* Double click expands the panel

Co-authored-by: Pascal Birchler <pascalb@google.com>
swissspidy added a commit that referenced this pull request Mar 30, 2020
* Adapt initial layer panel height to layer numbers

* Support double click on layer panel drag handle to reset height (#717)

* Added maximum initial layer number to show

* Rethink collapse/expand logic

* Fixed issue that broke tests

* Double click expands the panel

Co-authored-by: Pascal Birchler <pascalb@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Enhancement New feature or improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants