Skip to content

Performance & aesthetic improvements for drop targets#687

Merged
wassgha merged 7 commits intomasterfrom
drop-targets-nits
Mar 24, 2020
Merged

Performance & aesthetic improvements for drop targets#687
wassgha merged 7 commits intomasterfrom
drop-targets-nits

Conversation

@wassgha
Copy link
Copy Markdown
Contributor

@wassgha wassgha commented Mar 21, 2020

Closes #645
Closes #642
Closes #635
Closes #647
Closes #634

Changes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 21, 2020

Size Change: +221 B (0%)

Total Size: 433 kB

Filename Size Change
assets/js/edit-story.js 369 kB +221 B (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 241 B 0 B
assets/css/stories-dashboard.css 206 B 0 B
assets/js/stories-dashboard.js 63.4 kB 0 B

compressed-size-action

@swissspidy swissspidy added the Type: Enhancement New feature or improvement of an existing feature label Mar 22, 2020
@miina
Copy link
Copy Markdown
Contributor

miina commented Mar 23, 2020

@wassgha
From testing:
Still seeing #645 -- when dragging an image, a previously selected Text box still has the selection outline which is also blue and isn't distinguished from the drop targets.

642 and 647 seem to work well now 👍

@wassgha wassgha force-pushed the drop-targets-nits branch from b213fc1 to dc4cf67 Compare March 24, 2020 01:42
@wassgha wassgha force-pushed the drop-targets-nits branch from dc4cf67 to c93ef62 Compare March 24, 2020 01:50
@wassgha wassgha merged commit c41512f into master Mar 24, 2020
@wassgha wassgha deleted the drop-targets-nits branch March 24, 2020 02:00
obetomuniz added a commit that referenced this pull request Mar 24, 2020
* master: (89 commits)
  Bump webpack from 4.42.0 to 4.42.1 (#740)
  Lint fixes
  Move DEFAULT_LINK declaration to within LinkPanel
  Bump lint-staged from 10.0.8 to 10.0.9 (#728)
  Fix clip path on iOS Chrome (#727)
  Bump @wordpress/components from 9.2.4 to 9.2.5 (#722)
  Performance & aesthetic improvements for drop targets (#687)
  Fix LinkType default arg hack due to module loading errors
  Temp fix for LinkType problem
  lints
  Bump prettier from 2.0.1 to 2.0.2 (#721)
  Lots and lots and lots of tests
  fixed tests
  transparent color formatting
  Color migrated
  Migrated most of the panels, except for color
  Save on selection change
  News tests for DesignPanel and related features
  Auto-submit for all forms
  Text style support
  ...
obetomuniz added a commit that referenced this pull request Mar 24, 2020
* master: (81 commits)
  Bump webpack from 4.42.0 to 4.42.1 (#740)
  Lint fixes
  Move DEFAULT_LINK declaration to within LinkPanel
  Bump lint-staged from 10.0.8 to 10.0.9 (#728)
  Fix clip path on iOS Chrome (#727)
  Bump @wordpress/components from 9.2.4 to 9.2.5 (#722)
  Performance & aesthetic improvements for drop targets (#687)
  Fix LinkType default arg hack due to module loading errors
  Temp fix for LinkType problem
  lints
  Bump prettier from 2.0.1 to 2.0.2 (#721)
  Lots and lots and lots of tests
  fixed tests
  transparent color formatting
  Color migrated
  Migrated most of the panels, except for color
  Save on selection change
  News tests for DesignPanel and related features
  Auto-submit for all forms
  Text style support
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Enhancement New feature or improvement of an existing feature

Projects

None yet

5 participants