Skip to content

Add mbstring polyfill#4908

Merged
swissspidy merged 1 commit intomainfrom
add/4898-mbstring-polyfill
Oct 16, 2020
Merged

Add mbstring polyfill#4908
swissspidy merged 1 commit intomainfrom
add/4898-mbstring-polyfill

Conversation

@swissspidy
Copy link
Copy Markdown
Collaborator

@swissspidy swissspidy commented Oct 16, 2020

Summary

Adds a polyfill for mbstring if it's missing on the server.

The polyfill Mbstring code is prefixed in order to avoid conflicts with other plugins using the same library.

Relevant Technical Choices

To-do

User-facing changes

N/A

Testing Instructions

N/A

Fixes #4898

@swissspidy swissspidy added Group: Integration Integration with other platforms and plugins Group: WordPress Changes related to WordPress or Gutenberg integration Pod: WP & Infra labels Oct 16, 2020
@google-cla google-cla bot added the cla: yes label Oct 16, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 16, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 1.38 MB

ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 909 B 0 B
assets/css/stories-dashboard.css 939 B 0 B
assets/css/web-stories-embed-block.css 515 B 0 B
assets/js/chunk-fonts-********************.js 43.6 kB 0 B
assets/js/chunk-web-stories-template-0-********************.js 10.2 kB 0 B
assets/js/chunk-web-stories-template-1-********************.js 10.2 kB 0 B
assets/js/chunk-web-stories-template-2-********************.js 9.97 kB 0 B
assets/js/chunk-web-stories-template-3-********************.js 10.5 kB 0 B
assets/js/chunk-web-stories-template-4-********************.js 10.6 kB 0 B
assets/js/chunk-web-stories-template-5-********************.js 6.83 kB 0 B
assets/js/chunk-web-stories-template-6-********************.js 9.87 kB 0 B
assets/js/chunk-web-stories-template-7-********************.js 9.75 kB 0 B
assets/js/chunk-web-stories-textset-0-********************.js 5.25 kB 0 B
assets/js/chunk-web-stories-textset-1-********************.js 6.13 kB 0 B
assets/js/chunk-web-stories-textset-2-********************.js 6.67 kB 0 B
assets/js/chunk-web-stories-textset-3-********************.js 14.3 kB 0 B
assets/js/chunk-web-stories-textset-4-********************.js 3.77 kB 0 B
assets/js/chunk-web-stories-textset-5-********************.js 4.47 kB 0 B
assets/js/chunk-web-stories-textset-6-********************.js 4.65 kB 0 B
assets/js/chunk-web-stories-textset-7-********************.js 9.65 kB 0 B
assets/js/edit-story.js 522 kB 0 B
assets/js/stories-dashboard.js 585 kB 0 B
assets/js/web-stories-activation-notice.js 74.1 kB 0 B
assets/js/web-stories-embed-block.js 17.3 kB 0 B

compressed-size-action

@swissspidy swissspidy force-pushed the add/4898-mbstring-polyfill branch from bc07671 to 83afbdc Compare October 16, 2020 14:09
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2020 •
edited
Loading

Codecov Report

Merging #4908 into main will increase coverage by 0.71%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4908      +/-   ##
==========================================
+ Coverage   75.97%   76.69%   +0.71%     
==========================================
  Files         901      902       +1     
  Lines       16005    16044      +39     
==========================================
+ Hits        12160    12305     +145     
+ Misses       3845     3739     -106
Flag Coverage Δ
#karmatests 55.50% <ø> (+2.90%) ⬆️
#unittests 65.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
includes/polyfills/mbstring.php 0.00% <0.00%> (ø)
...ets/src/edit-story/components/elementLink/frame.js 43.75% <0.00%> (-56.25%) ⬇️
assets/src/edit-story/utils/url.js 25.00% <0.00%> (-50.00%) ⬇️
assets/src/edit-story/components/form/link.js 50.00% <0.00%> (-42.86%) ⬇️
...ets/src/edit-story/components/panels/link/index.js 53.44% <0.00%> (-37.94%) ⬇️
...rc/edit-story/components/canvas/selectionCanvas.js 54.11% <0.00%> (-21.18%) ⬇️
...it-story/components/library/panes/text/textIcon.js 81.81% <0.00%> (-18.19%) ⬇️
assets/src/edit-story/utils/isMouseUpAClick.js 83.33% <0.00%> (-16.67%) ⬇️
.../edit-story/components/canvas/useEditingElement.js 76.47% <0.00%> (-11.77%) ⬇️
assets/src/edit-story/components/form/media.js 80.00% <0.00%> (-8.89%) ⬇️
... and 37 more

@swissspidy swissspidy force-pushed the add/4898-mbstring-polyfill branch from 83afbdc to b77a8d3 Compare October 16, 2020 14:18
spacedmonkey
spacedmonkey approved these changes Oct 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Simple and clean. 👍

@swissspidy swissspidy force-pushed the add/4898-mbstring-polyfill branch from b77a8d3 to c26f541 Compare October 16, 2020 15:45
@swissspidy swissspidy added the Type: Enhancement New feature or improvement of an existing feature label Oct 16, 2020
@swissspidy swissspidy merged commit 8d6e611 into main Oct 16, 2020
@swissspidy swissspidy deleted the add/4898-mbstring-polyfill branch October 16, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@spacedmonkey spacedmonkey spacedmonkey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Group: Integration Integration with other platforms and plugins Group: WordPress Changes related to WordPress or Gutenberg integration Type: Enhancement New feature or improvement of an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include mbstring polyfill

2 participants

@swissspidy @spacedmonkey