-
Notifications
You must be signed in to change notification settings - Fork 194
Include mbstring polyfill #4898
Copy link
Copy link
Closed
Labels
AMP OutputIssues related to AMP output and validationIssues related to AMP output and validationGroup: WordPressChanges related to WordPress or Gutenberg integrationChanges related to WordPress or Gutenberg integrationType: EnhancementNew feature or improvement of an existing featureNew feature or improvement of an existing feature
Description
Feature Description
For parsing and rendering the story markup in the correct way, we use mb_convert_encoding to fix the encoding if needed. That function is part of the mbstring extension which can be missing or outdated on certain servers.
We can include https://github.com/symfony/polyfill-mbstring/ as a polyfill for these cases.
This should reduce the number of support requests where users report mangled umlauts due to inproper encoding.
Setup should be straightforward:
composer require symfony/polyfill-mbstring- Update
scoper.inc.phpto prefixsymfony/polyfill-mbstringdependencies correctly
Alternatives Considered
Additional Context
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
Implementation Brief
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
AMP OutputIssues related to AMP output and validationIssues related to AMP output and validationGroup: WordPressChanges related to WordPress or Gutenberg integrationChanges related to WordPress or Gutenberg integrationType: EnhancementNew feature or improvement of an existing featureNew feature or improvement of an existing feature