chore: Fix BuildContextCompressionLevel description, output the level #9688
Conversation
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
|
Gemini encountered an error creating the summary. You can try again by commenting |
|
Thanks for the change @idsulik, although since there is no explicit request for this, I don't think it's necessary. |
|
@katiexzhang , what do you mean? the description isn't full, how does the user should know what value they can use and what does it mean? |
https://skaffold.dev/docs/references/yaml/#build-artifacts-kaniko-buildContextCompressionLevel who knows what compression levels gzip has? I didn't even know until I made this feature. |
katiexzhang
left a comment
There was a problem hiding this comment.
Where are you getting these descriptions from, specifically the -2? If possible, could you use the description from public docs, like https://docs.python.org/3/library/gzip.html.
Also I think you accidentally removed the default value.
|
| "type": "integer", | ||
| "description": "gzip compression level for the build context.", | ||
| "x-intellij-html-description": "gzip compression level for the build context.", | ||
| "default": "1" |
There was a problem hiding this comment.
This line was removed: "default": "1"
There was a problem hiding this comment.
oh, sorry, haven't noticed it. pushed fix
…GoogleContainerTools#9688) * chore: Fix BuildContextCompressionLevel description, output the level Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> * fixes Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> --------- Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Description
BuildContextCompressionLeveldescriptionusing gzip compression level {level}