fix: keep the original template if template expansion fails #9503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renzodavid9
approved these changes
Aug 21, 2024
ericzzzzzzz
added a commit
to ericzzzzzzz/skaffold
that referenced
this pull request
Aug 21, 2024
…ntainerTools#9503) * fix: keep the original template if template expansion fails * fix: keep the original template if template expansion fails
ericzzzzzzz
added a commit
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skaffold diagnosecommand because users may not have some values from build available when running this if they have helm deployer/renderer setTemplates configured."repo.tag": {{IMAGE_TAG_BUILD_ARTFIACT_NAME}}, not available in diagnose stage, but it will be provided through--build-artifactsflag inrenderstage.