feat: Optimize helm deploy by using goroutines #9451
Conversation
44fb2b8 to
d1f1046
Compare
f3adb33 to
383b26e
Compare
pkg/skaffold/deploy/helm/helm.go
Outdated
| manifests := manifest.ManifestList{} | ||
| g, ctx := errgroup.WithContext(ctx) | ||
|
|
||
| if h.Concurrency != nil && *h.Concurrency == 1 { |
There was a problem hiding this comment.
Hi @idsulik, thanks for this PR! Would you be able to add tests for both Sequential and Concurrent installation cases?
There was a problem hiding this comment.
hi @alphanota, pushed changes. by default it keeps the old behavior (sequential order), but a user can change it using the config file.
Please check this PR as well #9520, because it's very important, if something goes wrong with helm package installation, user will have package in pending state, because skaffold kills the helm command, so the user needs to manually uninstall/rollback the pending release
383b26e to
b07b960
Compare
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
b07b960 to
252d836
Compare
…erTools#9451)" This reverts commit 3f2e8df.
(c) skaffold slack https://kubernetes.slack.com/archives/CABQMSZA6/p1732688941159699 |
|
the result is perfect!) |
|
Is there any documentation around how to use this feature ? |
|
@Oden22 hi! It's pretty simple:
That's it |
Description
in my case:
before: Deploy completed in 3 minutes 52.351 seconds
after: Deploy completed in 1 minute 57.148 seconds
colleague:
before: Deploy completed in 4 minutes 4.594 seconds
after: Deploy completed in 53.423 seconds