Use Gradle Property and Provider to enable lazy evaluation for jib.container.labels (#3094)#3242
Merged
chanseokoh merged 1 commit intoGoogleContainerTools:masterfrom May 18, 2021
Conversation
Member
|
Thanks! There's a formatting violation that's causing unit-tests failures. You can auto-format the code with |
chanseokoh
reviewed
May 17, 2021
jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/ContainerParameters.java
Outdated
Show resolved
Hide resolved
chanseokoh
reviewed
May 18, 2021
jib-gradle-plugin/src/test/java/com/google/cloud/tools/jib/gradle/JibExtensionTest.java
Show resolved
Hide resolved
jib-gradle-plugin/src/test/java/com/google/cloud/tools/jib/gradle/JibExtensionTest.java
Show resolved
Hide resolved
jib-gradle-plugin/src/test/java/com/google/cloud/tools/jib/gradle/JibExtensionTest.java
Outdated
Show resolved
Hide resolved
...radle-plugin/src/test/java/com/google/cloud/tools/jib/gradle/GradleRawConfigurationTest.java
Outdated
Show resolved
Hide resolved
jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/ContainerParameters.java
Outdated
Show resolved
Hide resolved
27dc237 to
6598b69
Compare
chanseokoh
approved these changes
May 18, 2021
Member
chanseokoh
left a comment
There was a problem hiding this comment.
Awesome, thanks for your contribution! Merging this now.
Merged
Contributor
Author
|
Thank you @chanseokoh for your guidance. Looking forward to help with other issues ! |
rm3l
added a commit
to Cosmo-Tech/cosmotech-api
that referenced
this pull request
Jun 11, 2021
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Gradle Property and Provider to enable lazy evaluation for jib.container.labels (#3094)