Refactor out common test classes into new test project#2350
Refactor out common test classes into new test project#2350loosebazooka merged 5 commits intomasterfrom
Conversation
|
hrmm, something strange is happening with packaging now, not sure why |
583e52d to
bb76b94
Compare
chanseokoh
left a comment
There was a problem hiding this comment.
Should we move these too?
HttpGetVerifier
PlainHttpClient
RequestWrapper
And I guess it's not our intention to move Gradle and Maven-specific test helpers, right?
- Gradle:
TestProject,JibRunHelper - Maven:
TestProject,TestRepository,SkippedGoalVerifier,SettingsFixture
| <suppress files=".*[\\/]HelpfulSuggestions\.java" checks="MissingJavadocMethod"/> | ||
|
|
||
| <!-- leniency for test files --> | ||
| <suppress files=".*[\\/]jib-testing-common[\\/].*\.java" checks ="MissingJavadocMethod"/> |
There was a problem hiding this comment.
I wonder if we can start the pattern with jib-testing-common[\\/] without ."[\\/]?
There was a problem hiding this comment.
I don't know if it matters, I guess this is a little more strict: /jib-testing-common/ instead of abc-jib-testing-common/
jib-gradle-plugin/build.gradle
Outdated
|
|
||
| testImplementation project(path:':jib-plugins-common', configuration:'tests') | ||
| integrationTestImplementation project(path:':jib-core', configuration:'integrationTests') | ||
| testImplementation project(path:':jib-testing-common') |
There was a problem hiding this comment.
nit: for consistency, testImplementation project(':jib-testing-common') (without specifying the path argument name).
And does the order of testImplementation matter? In jib-core, it's the first entry.
jib-maven-plugin/build.gradle
Outdated
|
|
||
| testImplementation project(path:':jib-plugins-common', configuration:'tests') | ||
| integrationTestImplementation project(path:':jib-core', configuration:'integrationTests') | ||
| testImplementation project(path:':jib-testing-common') |
So these aren't shared by anyone, I guess if we want to eventually export them we can? But there's no need to now. |
This reverts commit dce2f87.
This reverts commit dce2f87.
This reverts commit dce2f87.
part of #2150
jib-testing-common)jib-testing-commonjib-testing-common