This repository was archived by the owner on Nov 27, 2024. It is now read-only.
Check folder change before using v3 API#770
Merged
Merged
Conversation
melinath
suggested changes
Jun 15, 2022
melinath
approved these changes
Jun 15, 2022
melinath
left a comment
Member
There was a problem hiding this comment.
LGTM apart from a few minor fixes to the names for the new tests & logic for one.
melinath
approved these changes
Jun 15, 2022
| v1Count: 1, | ||
| }, | ||
| { | ||
| // project moving from organizations/qux/folders/bar to organizations/qux2/folders/bar2 |
Member
There was a problem hiding this comment.
💯 great to have this added information in the comments!
melinath
pushed a commit
that referenced
this pull request
Jun 16, 2022
* Check folder change before using v3 API * address case to move folder between parent and child * Fix wrong test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.