Skip to content
This repository was archived by the owner on Nov 27, 2024. It is now read-only.

Provide URL along with error message for resourcemanager.projects.get #743

Merged
melinath merged 3 commits into
GoogleCloudPlatform:mainfrom
prateek2408:add_url_with_error_messge
Jun 6, 2022
Merged

Provide URL along with error message for resourcemanager.projects.get #743
melinath merged 3 commits into
GoogleCloudPlatform:mainfrom
prateek2408:add_url_with_error_messge

Conversation

@prateek2408

Copy link
Copy Markdown
Contributor

Fix for issue #536 .

Adding an extra message that provides the documentation to fix project permission issues

@prateek2408 prateek2408 requested review from a team and melinath and removed request for a team June 3, 2022 15:59
@prateek2408 prateek2408 changed the title Provide URL along with error message Provide URL along with error message for resourcemanager.projects.get Jun 3, 2022

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely looks like the right spot! Just a couple changes to request.

Comment thread ancestrymanager/ancestrymanager.go Outdated
@prateek2408 prateek2408 requested a review from melinath June 6, 2022 16:24

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melinath melinath merged commit 176fc91 into GoogleCloudPlatform:main Jun 6, 2022
@prateek2408 prateek2408 deleted the add_url_with_error_messge branch June 7, 2022 04:37
roaks3 pushed a commit that referenced this pull request Jun 15, 2022
…#743)

* Provide URL along with error message

* incoprating comments

* making the error message more informational
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants