Skip to content

Add option to set autoresize limit#709

Merged
modular-magician merged 1 commit into
GoogleCloudPlatform:masterfrom
modular-magician:downstream-pr-860b8443b1b3b916989b3899465e00d582aebdca
May 20, 2021
Merged

Add option to set autoresize limit#709
modular-magician merged 1 commit into
GoogleCloudPlatform:masterfrom
modular-magician:downstream-pr-860b8443b1b3b916989b3899465e00d582aebdca

Conversation

@modular-magician

Copy link
Copy Markdown
Collaborator

assisting with GoogleCloudPlatform/magic-modules#4647

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: added field `disk_autoresize_limit` to `sql_database_instance`

Derived from GoogleCloudPlatform/magic-modules#4743

Co-authored-by: Evy Bongers <evy@evybongers.nl>
Signed-off-by: Modular Magician <magic-modules@google.com>
@google-cla

google-cla Bot commented May 20, 2021

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no label May 20, 2021
@modular-magician modular-magician merged commit 0b21f40 into GoogleCloudPlatform:master May 20, 2021
@modular-magician modular-magician deleted the downstream-pr-860b8443b1b3b916989b3899465e00d582aebdca branch November 18, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant