Skip to content

Add option to set autoresize limit#4743

Merged
ScottSuarez merged 5 commits into
GoogleCloudPlatform:masterfrom
ScottSuarez:sql-instance-disk-autoresize-limit
May 20, 2021
Merged

Add option to set autoresize limit#4743
ScottSuarez merged 5 commits into
GoogleCloudPlatform:masterfrom
ScottSuarez:sql-instance-disk-autoresize-limit

Conversation

@ScottSuarez

@ScottSuarez ScottSuarez commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

assisting with #4647

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: added field `disk_autoresize_limit` to `sql_database_instance`

@google-cla

google-cla Bot commented Apr 28, 2021

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no label Apr 28, 2021
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 16 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 16 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=184701"

@ScottSuarez ScottSuarez requested a review from megan07 April 28, 2021 17:47
@google-cla

google-cla Bot commented May 19, 2021

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@ScottSuarez

Copy link
Copy Markdown
Contributor Author

@megan07 I upgraded the dependency. this should be good now

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 16 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 16 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=188263"

@google-cla

google-cla Bot commented May 19, 2021

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 16 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 4 files changed, 18 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=188269"

@modular-magician

Copy link
Copy Markdown
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccSqlDatabaseInstance_diskspecs You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=188281"

@megan07 megan07 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants