ci: do not run 3.6 tests by default by busunkim96 · Pull Request #7409 · GoogleCloudPlatform/python-docs-samples

busunkim96 · 2022-01-28T19:12:37Z

Python 3.6 went End-of-Life in December. This PR adds 3.6 to the default ignored_versions list in noxfile-template.py, noxfile.py andnoxfile_config.py files.

If we need to run 3.6 in any directories, we can use a noxfile_config that doesn't have 3.6 in the ignore list.

anguillanneuf

Looks good for Pub/Sub.

leahecole · 2022-01-28T19:23:40Z

LGTM for data science onramp

dataflow/encryption-keys/noxfile_config.py

busunkim96 · 2022-02-08T22:17:29Z

ml_engine/online_prediction/noxfile_config.py

 TEST_CONFIG_OVERRIDE = {
    # You can opt out from the test for specific Python versions.
-    "ignored_versions": ["2.7", "3.8", "3.9", "3.10"],
+    "ignored_versions": ["2.7", "3.6", "3.8", "3.9", "3.10"],


@alecglassford We have you listed in CODEOWNERS for ml_engine, would you know if this change is OK to take?

@busunkim96 Hi! I no longer work at the company, so I'm not a good person to answer this question. (You should probably also remove me from CODEOWNERS; sorry that I didn't think to do this before I left!)

@nicain can you take a look at this?

@ivanmkc PTAL

busunkim96 · 2022-02-08T22:20:49Z

notebooks/noxfile_config.py

    # You can opt out from the test for specific Python versions.
    # Skipping for Python 3.9 due to pyarrow compilation failure.
-    "ignored_versions": ["2.7", "3.9"],
+    "ignored_versions": ["2.7", "3.6", "3.9"],


This directory doesn't seem to have any .py files, maybe the noxfile.py and noxfile_config.py should be deleted? https://github.com/GoogleCloudPlatform/python-docs-samples/tree/main/notebooks

Let's check in with @ivanmkc and/or @loferris who know a ton about the current notebooks testing strategy. My instinct is to say that's probably fine to remove those but I want an LGTM from one of those two folks 😄

I think it's fine to remove them! We don't currently use nox on notebooks - we should be able to do CI testing on notebooks once we've added the testing pipeline to this repo. LGTM

dataflow/encryption-keys/noxfile_config.py

nicain · 2022-02-22T19:31:53Z

ml_engine/online_prediction/noxfile_config.py

 TEST_CONFIG_OVERRIDE = {
    # You can opt out from the test for specific Python versions.
-    "ignored_versions": ["2.7", "3.8", "3.9", "3.10"],
+    "ignored_versions": ["2.7", "3.6", "3.8", "3.9", "3.10"],


@ivanmkc PTAL

dandhlee · 2022-02-22T19:55:43Z

.github/CODEOWNERS

 /media/**/*.py                         @irataxy @GoogleCloudPlatform/python-samples-owners
 /memorystore/**/*.py                   @GoogleCloudPlatform/python-samples-owners
-/ml_engine/**/*.py                     @alecglassford @GoogleCloudPlatform/python-samples-owners
+/ml_engine/**/*.py                     @ivanmkc @GoogleCloudPlatform/python-samples-owners


@nicain could you take this change onto a separate PR?

davidcavazos · 2022-02-22T20:19:33Z

LGTM for Dataflow related samples.

leahecole · 2022-02-23T22:54:02Z

@engelke does this look ok for appengine?

busunkim96 · 2022-02-24T22:26:38Z

@nicain Could you re-review this PR?

Copied from GoogleCloudPlatform/python-docs-samples#7409

Copied from GoogleCloudPlatform/python-docs-samples#7409 Co-authored-by: Anna Cocuzzo <63511057+acocuzzo@users.noreply.github.com>

ci: do not run 3.6 tests by default

632ad33

busunkim96 requested review from a team, alixhami, anguillanneuf, bradmiro, davidcavazos, hongalex, leahecole and shollyman as code owners January 28, 2022 19:12

product-auto-label bot added the samples Issues that are directly related to samples. label Jan 28, 2022

blunderbuss-gcf bot assigned engelke Jan 28, 2022

Merge branch 'main' into remove-3-6

70ee859

anguillanneuf approved these changes Jan 28, 2022

View reviewed changes

leahecole mentioned this pull request Jan 28, 2022

chore(deps): update dependency google-cloud-storage to v2 #7362

Merged

1 task

parthea approved these changes Feb 7, 2022

View reviewed changes

shollyman approved these changes Feb 7, 2022

View reviewed changes

Merge branch 'main' into remove-3-6

0c60a28

busunkim96 commented Feb 8, 2022

View reviewed changes

busunkim96 mentioned this pull request Feb 14, 2022

chore(deps): update dependency google-api-python-client to v2.37.0 #7376

Merged

1 task

This was referenced Feb 19, 2022

chore(deps): bump tensorflow from 2.7.0 to 2.8.0 in /ml_engine/online_prediction #7474

Merged

chore(deps): update dependency google-auth to v2.5.0 #7391

Merged

Merge branch 'main' into remove-3-6

f8d3651

nicain requested changes Feb 22, 2022

View reviewed changes

Remove alecglassford and replace ivanmkc as CODEOWNER of ml_engine

b232929

dandhlee reviewed Feb 22, 2022

View reviewed changes

davidcavazos approved these changes Feb 22, 2022

View reviewed changes

busunkim96 requested a review from nicain February 23, 2022 15:51

This was referenced Feb 23, 2022

chore(deps): update dependency pytest to v7 #7431

Merged

chore: remove noxfile_config from directory with no .py files #7508

Merged

Merge branch 'main' into remove-3-6

bae38c2

busunkim96 requested a review from a team as a code owner February 25, 2022 18:55

chore: revert changes to codeowners

cf39902

nicain approved these changes Feb 25, 2022

View reviewed changes

leahecole merged commit 79e32fd into main Feb 25, 2022

leahecole deleted the remove-3-6 branch February 25, 2022 19:52

meredithslota added a commit to googleapis/python-pubsub that referenced this pull request Mar 10, 2023

ci: do not run 3.6 tests by default

fdb373f

Copied from GoogleCloudPlatform/python-docs-samples#7409

meredithslota mentioned this pull request Mar 10, 2023

ci: do not run 3.6 tests by default googleapis/python-pubsub#880

Merged

acocuzzo added a commit to googleapis/python-pubsub that referenced this pull request Apr 1, 2023

ci: do not run 3.6 tests by default (#880)

9ff7937

Copied from GoogleCloudPlatform/python-docs-samples#7409 Co-authored-by: Anna Cocuzzo <63511057+acocuzzo@users.noreply.github.com>

parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Mar 2, 2026

ci: do not run 3.6 tests by default (#880)

f5f451d

Copied from GoogleCloudPlatform/python-docs-samples#7409 Co-authored-by: Anna Cocuzzo <63511057+acocuzzo@users.noreply.github.com>

Conversation

busunkim96 commented Jan 28, 2022

Uh oh!

anguillanneuf left a comment

Choose a reason for hiding this comment

Uh oh!

leahecole commented Jan 28, 2022

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicain Feb 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nicain Feb 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidcavazos commented Feb 22, 2022

Uh oh!

leahecole commented Feb 23, 2022

Uh oh!

busunkim96 commented Feb 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

nicain Feb 22, 2022 •

edited

Loading

nicain Feb 22, 2022 •

edited

Loading