Skip to content

Django_cloudsql config edits#700

Merged
waprin merged 1 commit intomasterfrom
django_cloudsql-config-changes
Dec 7, 2016
Merged

Django_cloudsql config edits#700
waprin merged 1 commit intomasterfrom
django_cloudsql-config-changes

Conversation

@ryanmats
Copy link
Copy Markdown
Contributor

@ryanmats ryanmats commented Dec 7, 2016

Tweaked a few placeholder names for variables users should change before testing/deploying. The tutorial is now going to ask them to create a non-root username/password. Also updated environment variable that changed because of flex beta 2.

Tweaked a few placeholder names for variables users should change before testing/deploying. Also updated environment variable that changed because of flex beta 2.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2016
# to the instance
DATABASES['default']['HOST'] = '/cloudsql/<your-cloudsql-connection-string>'
if os.getenv('GAE_APPENGINE_HOSTNAME'):
if os.getenv('GAE_INSTANCE'):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change only makes sense if you switch it to env: flex, which we haven't done yet?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow yes we have...was it broken before?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure. Once I finish updating the tutorial I'm gonna go through it end-to-end to make sure it all works.

@waprin waprin merged commit cecc8a0 into master Dec 7, 2016
@ryanmats ryanmats deleted the django_cloudsql-config-changes branch December 7, 2016 01:02
chalmerlowe pushed a commit that referenced this pull request Feb 19, 2026
* feat: Add support for python 3.11

chore: Update gapic-generator-python to v1.8.0
PiperOrigin-RevId: 500768693

Source-Link: googleapis/googleapis@190b612

Source-Link: https://github.com/googleapis/googleapis-gen/commit/7bf29a414b9ecac3170f0b65bdc2a95705c0ef1a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* require proto-plus 1.22.2 for python 3.11

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants