Add structured reporting diff to BigQueryAnalyticsHubDataExchange#6774
Merged
Conversation
Collaborator
Author
|
@acpana pls do first round review. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
via the queue into
GoogleCloudPlatform:master
with commit Mar 18, 2026
a86a418
166 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BRIEF Change description
Fixes a bug in the BigQueryAnalyticsHub DataExchange controller, adds structured diff reporting for updates, and updates tests to cover all mutable fields.
Fixes #6540
WHY do we need this change?
The Update method in the DataExchange controller had several issues that needed to be addressed for correctness and standard compliance:
structuredreporting.Diffto improve visibility into resource changes during reconciliation.discoveryType: The previous implementation compared a string pointer with a proto enum string incorrectly. It now compares the converted proto values.Updatelogic to convert the desired state to its proto representation earlier. This ensures that field comparisons are performed between the same types (proto to proto), avoiding potentialDeepEqualfailures due to type mismatches.setStatus: Updated thesetStatuscall to use the correct unstructured object from theUpdateOperation, ensuring status updates are correctly persisted.bigqueryanalyticshubdataexchange-fulltest fixture to include changes to all mutable fields (displayName,description, etc.) to verify the fix and ensure all fields are correctly updated in GCP.Special notes for your reviewer:
Does this PR add something which needs to be 'release noted'?
Additional documentation e.g., references, usage docs, etc.:
Intended Milestone
Tests you have done
make ready-prto ensure this PR is ready for review.