Update Maven config GAE 11 #2441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesv
suggested changes
Mar 19, 2020
appengine-java11/gaeinfo/README.md
Outdated
| - Deploy to App Engine standard environment using the following Maven command. | ||
| ``` | ||
| mvn appengine:deploy -Dapp.deploy.projectId=<your-project-id> | ||
| mvn clean package appengine:deploy -Dapp.deploy.projectId=<your-project-id> |
Contributor
There was a problem hiding this comment.
let's remove -Dapp.deploy.projectId=<your-project-id>
appengine-java11/kotlin-ktor/pom.xml
Outdated
| <id>repo1</id> | ||
| <url>https://jcenter.bintray.com</url> | ||
| <releases><enabled>true</enabled></releases> | ||
| <snapshots><enabled>true</enabled></snapshots> |
Contributor
There was a problem hiding this comment.
Probably want that to be false -- we don't want snapshots
appengine-java11/kotlin-ktor/pom.xml
Outdated
| <id>repo2</id> | ||
| <url>https://kotlin.bintray.com/ktor</url> | ||
| <releases><enabled>true</enabled></releases> | ||
| <snapshots><enabled>true</enabled></snapshots> |
Contributor
There was a problem hiding this comment.
we also don't want them here.
Contributor
Author
|
@lesv ready for review. Thanks |
lesv
approved these changes
Mar 20, 2020
olavloite
pushed a commit
to olavloite/java-docs-samples
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.