Skip to content

httplib2 was wrongly parsing bar in bar@host as password before v0.20.4#1468

Merged
NickGoog merged 2 commits intoGoogleCloudPlatform:masterfrom
temoto:patch-1
Feb 24, 2022
Merged

httplib2 was wrongly parsing bar in bar@host as password before v0.20.4#1468
NickGoog merged 2 commits intoGoogleCloudPlatform:masterfrom
temoto:patch-1

Conversation

@temoto
Copy link
Copy Markdown
Contributor

@temoto temoto commented Feb 23, 2022

Obviously wrong because there is no username before that password.

fixed by: httplib2/httplib2#217
upstream issue: httplib2/httplib2#218

@temoto
httplib2 was wrongly parsing bar in bar@host as password before v…
be69890 
…0.20.4

obviously wrong because there is no username before that password

fixed by: httplib2/httplib2#217
upstream issue: httplib2/httplib2#218
@dilipped
Copy link
Copy Markdown
Collaborator

dilipped commented Feb 23, 2022

@NickGoog this is probably related to the pip issue that you encountered during the release.

@NickGoog
Copy link
Copy Markdown
Contributor

NickGoog commented Feb 23, 2022

Our presubmits seem to be on httplib2 version 0.18.1, whereas the pip install uses the latest version 0.20.4. I'll look into fixing these presubmits to let this delightful PR in.

@NickGoog
Copy link
Copy Markdown
Contributor

NickGoog commented Feb 24, 2022

I just ran:

$ git clone git@github.com:temoto/gsutil.git
$ git fetch origin patch-1
$ git checkout patch-1
$ git submodule update --recursive --init
$ cd third_party/httplib2
echo "See old version"
$ head CHANGELOG 
$ git pull origin master
echo "See new version :) "
$ head CHANGELOG 
$ cd ../..
$ git add .
$ git commit -m "Bump httplib2 submodule version to latest"
echo "I wasn't actually expecting the below to allow me to edit someone else's PR haha"
$ git push

But it seems like this introduces new dependencies through the updated httplib2, so the tests will still fail. Will work on this again later this week.

@NickGoog
Bumb httplib2 submodule version to latest and add new httplib2
83e521d 
dependency.

Was careful to choose a pyparsing version that supports Py3.5 and
httplib2 version requirements, by checking out the "pyparsing_2.4.x"
branch.

https://pypi.org/project/pyparsing/2.4.7/
https://github.com/httplib2/httplib2/blob/master/requirements.txt
@NickGoog NickGoog merged commit 52c9a5f into GoogleCloudPlatform:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@temoto @dilipped @NickGoog @gsutil-team-kokoro