0.20.4 broke test in gsutil that expected bar in bar@host to be a password #218
Description
Possibly related to #217
$ pip install httplib2==0.20.2
...
$ gsutil test gslib.tests.test_util.TestUtil.testProxyInfoFromEnvironmentVar
1/1 finished - E[0] F[0] s[0] - TestUtil.testProxyInfoFromEnvironmentVar - .
----------------------------------------------------------------------
Ran 1 test in 0.003s
OK
$ pip install httplib2 --upgrade
...
Successfully installed httplib2-0.20.4
$ gsutil test gslib.tests.test_util.TestUtil.testProxyInfoFromEnvironmentVar
1/1 finished - E[0] F[0] s[0] - TestUtil.testProxyInfoFromEnvironmentVar - F
======================================================================
FAIL: testProxyInfoFromEnvironmentVar (gslib.tests.test_util.TestUtil)
...
AssertionError: None != 'bar'
Test code (simplified):
def testProxyInfoFromEnvironmentVar(self):
self.assertEqual(
httplib2.proxy_info_from_url(
'http://bar@1.2.3.4:50', method='http').proxy_pass,
httplib2.ProxyInfo(
httplib2.socks.PROXY_TYPE_HTTP, '1.2.3.4', 50, proxy_pass='bar').proxy_pass)
Notes:
- Testing against 0.20.2 b/c I didn't see a 0.20.3 under PIP releases.
- Heavily simplified the actual gustil test case, which is why the test body has nothing to do with the title. The discrepency between versions 0.20.2 and 0.20.4 is reproducible with this short piece of code.
Thanks for any help!