Merge config-cli changes to master#2077
Merged
Merged
Conversation
* dont use custom type strings in legacy mount config * flaky test fixes
* changes to populate config * remove unecessary change * add client protocol changes * review comments * review comment * rebase changes * review comments * review comment + unit tests * review comment
* remove key file flag usage * typo fix * review comment Co-authored-by: Kislay Kishore <kislayk@google.com> * review comment Co-authored-by: Kislay Kishore <kislayk@google.com> * remove unexported method test --------- Co-authored-by: Kislay Kishore <kislayk@google.com>
Merge master into CLI_config_parity_release
…#2062) * removed log-file legacy usage * migrate log file flag * fix integration test * add unit test
Merge master into CLI_config_parity_release
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2077 +/- ##
==========================================
+ Coverage 71.98% 72.26% +0.28%
==========================================
Files 100 100
Lines 11207 10950 -257
==========================================
- Hits 8067 7913 -154
+ Misses 2806 2709 -97
+ Partials 334 328 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashmeenkaur
approved these changes
Jun 28, 2024
ashmeenkaur
left a comment
Collaborator
There was a problem hiding this comment.
Please use rebase and merge
sethiay
approved these changes
Jun 28, 2024
sethiay
left a comment
Contributor
There was a problem hiding this comment.
Relying on Ashmeen's review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Link to the issue in case of a bug fix.
NA
Testing details