[Config CLI Parity] Remove custom type strings from legacy mount config#2060
Merged
ashmeenkaur merged 2 commits intoJun 25, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## CLI_config_parity_release #2060 +/- ##
============================================================
Coverage ? 71.99%
============================================================
Files ? 99
Lines ? 10869
Branches ? 0
============================================================
Hits ? 7825
Misses ? 2712
Partials ? 332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6a77191 to
5c39d59
Compare
kislaykishore
previously approved these changes
Jun 25, 2024
4beb095 to
e0e12da
Compare
kislaykishore
previously approved these changes
Jun 25, 2024
Tulsishah
previously approved these changes
Jun 25, 2024
The base branch was changed.
Tulsishah
approved these changes
Jun 25, 2024
sethiay
approved these changes
Jun 25, 2024
sethiay
left a comment
Contributor
There was a problem hiding this comment.
Relying on @Tulsishah & @kislaykishore review.
kislaykishore
pushed a commit
that referenced
this pull request
Jun 28, 2024
* dont use custom type strings in legacy mount config * flaky test fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Custom type strings are not understood by the default decode hook being used to convert legacy mount config to new config object (as part of the migration for CLI-config parity) so removing custom types from mount config.
Following custom types are removed:
type LogSeverity string
type CacheDir string
This PR is part of migration to new cobra/viper configs for CLI config parity. Making this change to help with decoding logic to convert old config to new one.
Link to the issue in case of a bug fix.
NA
Testing details