Skip to content

fix: Update the vpc module output name for additional network#5690

Merged
agrawalkhushi18 merged 1 commit into
GoogleCloudPlatform:developfrom
agrawalkhushi18:add-net-vpc
May 20, 2026
Merged

fix: Update the vpc module output name for additional network#5690
agrawalkhushi18 merged 1 commit into
GoogleCloudPlatform:developfrom
agrawalkhushi18:add-net-vpc

Conversation

@agrawalkhushi18

@agrawalkhushi18 agrawalkhushi18 commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR is a follow up fix for the PR#5652. It modifies the vpc module output name to avoid the auto-wiring conflicts with other modules schedmd-slurm-gcp-v6-nodeset .

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@agrawalkhushi18 agrawalkhushi18 added the release-bugfix Added to release notes under the "Bug fixes" heading. label May 20, 2026
@gemini-code-assist

gemini-code-assist Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the naming convention for the VPC module's network output. By renaming 'additional_networks' to 'instance_additional_networks', the codebase improves clarity regarding the output's function. The changes include updating the module definition, the corresponding documentation, and the example configuration that consumes this output.

Highlights

  • Renaming VPC Output: Renamed the 'additional_networks' output to 'instance_additional_networks' in the VPC module to better reflect its purpose.
  • Example Configuration Update: Updated the gke-a3-ultragpu example configuration to reference the newly renamed 'instance_additional_networks' output.
  • Documentation Update: Updated the VPC module README to reflect the change in the output variable name.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 20, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the additional_networks output to instance_additional_networks in the VPC module and updates its usage in the GKE A3 Ultra GPU example. The review feedback correctly identifies this as a breaking change and recommends maintaining the original output name as a deprecated alias in both the Terraform code and documentation to preserve backward compatibility for existing users.

Comment thread modules/network/vpc/outputs.tf
Comment thread modules/network/vpc/README.md
@agrawalkhushi18 agrawalkhushi18 marked this pull request as ready for review May 20, 2026 06:47
@agrawalkhushi18 agrawalkhushi18 requested a review from a team as a code owner May 20, 2026 06:47
SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes May 20, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrawalkhushi18 agrawalkhushi18 merged commit 748c87e into GoogleCloudPlatform:develop May 20, 2026
25 of 92 checks passed
kadupoornima pushed a commit to kadupoornima/cluster-toolkit that referenced this pull request May 25, 2026
@agrawalkhushi18 @kadupoornima
fix: Update the vpc module output name for additional network (Google…
504def7 
…CloudPlatform#5690)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agrawalkhushi18 @SwarnaBharathiMantena