Skip to content

fix(slurm): correct vNUMA socket and SMT thread calculations in util.py#5683

Merged
kadupoornima merged 2 commits into
GoogleCloudPlatform:developfrom
kadupoornima:issue
May 21, 2026
Merged

fix(slurm): correct vNUMA socket and SMT thread calculations in util.py#5683
kadupoornima merged 2 commits into
GoogleCloudPlatform:developfrom
kadupoornima:issue

Conversation

@kadupoornima

@kadupoornima kadupoornima commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR is a solution to the issue - #5668

This pull request updates the machine configuration logic for the Slurm GCP controller. It refines how sockets, threads, and cores are calculated for various instance families to better align with hardware specifications and instance template settings.

Changes:

  • Socket Configuration Updates: Updated the socket calculation logic to include support for n2d and n2 families, and refined the socket counts for c3 and c4 families.
  • Core and Thread Calculation Refinement: Improved the logic for calculating threads per core and cores per socket to ensure accurate machine configuration based on instance templates.

Tested locally to verify this change fixes the issue:

  • Deployed a simple slurm blueprint after making the changes required for the fix.
  • Ran the following commands after SSHing into the controller node.
  • cloud.conf:
    image
  • slurmd -C:
    image
  • We can see that the values match.

@kadupoornima kadupoornima requested a review from a team as a code owner May 19, 2026 08:10
@kadupoornima kadupoornima added the release-bugfix Added to release notes under the "Bug fixes" heading. label May 19, 2026
@gemini-code-assist

gemini-code-assist Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the machine configuration logic for the Slurm GCP controller. It refines how sockets, threads, and cores are calculated for various instance families to better align with hardware specifications and instance template settings.

Highlights

  • Socket Configuration Updates: Updated the socket calculation logic to include support for n2d and n2 families, and refined the socket counts for c3 and c4 families.
  • Core and Thread Calculation Refinement: Improved the logic for calculating threads per core and cores per socket to ensure accurate machine configuration based on instance templates.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 19, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request expands the sockets property in util.py to include logic for n2d, n2, and n1 machine families and updates the c3 and c4 socket counts. It also corrects the cores_per_socket calculation in template_machine_conf. Feedback suggests refactoring the complex nested ternary logic for c3 and c4 to improve maintainability and renaming the threadsPerCore variable to threads_per_core to adhere to PEP 8 naming conventions.

Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/util.py
Comment thread community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/util.py Outdated
@kadupoornima kadupoornima changed the title base fix(slurm): correct vNUMA socket and SMT thread calculations in util.py May 19, 2026
@kadupoornima kadupoornima merged commit f487887 into GoogleCloudPlatform:develop May 21, 2026
17 of 85 checks passed
@kadupoornima kadupoornima deleted the issue branch May 22, 2026 07:59
kadupoornima added a commit to kadupoornima/cluster-toolkit that referenced this pull request May 25, 2026
@kadupoornima
fix(slurm): correct vNUMA socket and SMT thread calculations in util.…
dc9dcff 
…py (GoogleCloudPlatform#5683)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramvs-gg vikramvs-gg vikramvs-gg approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kadupoornima @vikramvs-gg