Remove hpc-slurm-static blueprint#5672
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the repository by removing the 'hpc-slurm-static' blueprint and its associated testing infrastructure. The change was motivated by the blueprint's redundancy, as it did not provide any unique functionality or configuration compared to existing examples. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the hpc-slurm-static.yaml example blueprint, which demonstrated the creation of Slurm partitions with static compute nodes. Correspondingly, references to this example were removed from the examples/README.md, and the associated daily integration test configuration and variables were deleted. I have no feedback to provide as there were no review comments to assess.
f17c0f9
into
GoogleCloudPlatform:develop
This example demonstrates how to create a partition with static compute nodes. However, currently most machine learning examples use static partitions (with reservations), therefore this blueprint is redundant and can be removed.