Skip to content

[Telemetry] Capture exit code upon fatal command failures#5658

Merged
kadupoornima merged 2 commits into
GoogleCloudPlatform:developfrom
kadupoornima:exit-code
May 13, 2026
Merged

[Telemetry] Capture exit code upon fatal command failures#5658
kadupoornima merged 2 commits into
GoogleCloudPlatform:developfrom
kadupoornima:exit-code

Conversation

@kadupoornima

@kadupoornima kadupoornima commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request enhances the telemetry system by ensuring that diagnostic data is captured and sent even when the application encounters a fatal error. By introducing a hook in the logging infrastructure, the system can now reliably report command failures, providing better visibility into application crashes.

Changes:

  • Telemetry Improvement: Added a FatalHook mechanism to the logging package to ensure telemetry data is flushed during hard failures.
  • Command Failure Tracking: Implemented a hook in cmd/root.go that triggers telemetry collection with an exit code of 1 whenever a fatal error occurs.

Tested:

image

@kadupoornima kadupoornima requested a review from a team as a code owner May 13, 2026 09:37
@gemini-code-assist

gemini-code-assist Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the telemetry system by ensuring that diagnostic data is captured and sent even when the application encounters a fatal error. By introducing a hook in the logging infrastructure, the system can now reliably report command failures, providing better visibility into application crashes.

Highlights

  • Telemetry Improvement: Added a FatalHook mechanism to the logging package to ensure telemetry data is flushed during hard failures.
  • Command Failure Tracking: Implemented a hook in cmd/root.go that triggers telemetry collection with an exit code of 1 whenever a fatal error occurs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 13, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a FatalHook mechanism in the logging package to ensure telemetry data is flushed before the application exits on a fatal error. A review comment suggests moving the telemetry and hook initialization earlier in the startup sequence to capture failures that occur during initial dependency checks, ensuring more robust error reporting.

Comment thread cmd/root.go
@kadupoornima kadupoornima added the release-improvements Added to release notes under the "Improvements" heading. label May 13, 2026
@kadupoornima kadupoornima changed the title [Telemetry] Capture exit code upon command failures [Telemetry] Capture exit code upon fatal command failures May 13, 2026
@kadupoornima kadupoornima enabled auto-merge (squash) May 13, 2026 09:46
SwarnaBharathiMantena
SwarnaBharathiMantena reviewed May 13, 2026
View reviewed changes
Comment thread pkg/logging/logging.go
Comment thread cmd/root.go Outdated
Comment thread cmd/root.go Outdated
@kadupoornima kadupoornima merged commit 1c0ac68 into GoogleCloudPlatform:develop May 13, 2026
13 of 79 checks passed
@kadupoornima kadupoornima deleted the exit-code branch May 22, 2026 07:59
kadupoornima added a commit to kadupoornima/cluster-toolkit that referenced this pull request May 25, 2026
@kadupoornima
[Telemetry] Capture exit code upon fatal command failures (GoogleClou…
e208511 
…dPlatform#5658)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kadupoornima @SwarnaBharathiMantena