[Telemetry] Get blueprint even from deployment directory#5656
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the telemetry module's ability to retrieve blueprint configurations. By allowing the system to look for an expanded blueprint within a deployment directory's artifacts, it improves usability for commands that operate on deployment folders. The changes ensure that the system gracefully handles both direct file paths and directory paths, falling back to an empty configuration if a valid blueprint cannot be parsed. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the telemetry collector to correctly handle deployment directories by reading the expanded blueprint from the artifacts folder. It also improves error handling in the getBlueprint utility and adds a comprehensive suite of unit tests covering various input scenarios. I have no feedback to provide.
7ba4204
into
GoogleCloudPlatform:develop
This pull request enhances the telemetry module's ability to retrieve blueprint configurations. By allowing the system to look for an expanded blueprint within a deployment directory's artifacts, it improves usability for commands that operate on deployment folders. The changes ensure that the system gracefully handles both direct file paths and directory paths, falling back to an empty configuration if a valid blueprint cannot be parsed.
Changes:
getBlueprintfunction to correctly resolve the blueprint file when a deployment directory is provided as an argument.modulewriterto locate the expanded blueprint within the artifacts directory of a deployment folder.getBlueprintcovering valid files, deployment directories, and error scenarios.