Skip to content

Merge v1.89.0 into Develop#5577

Merged
siddhartha-quad merged 3 commits into
developfrom
main
Apr 30, 2026
Merged

Merge v1.89.0 into Develop#5577
siddhartha-quad merged 3 commits into
developfrom
main

Conversation

@siddhartha-quad

@siddhartha-quad siddhartha-quad commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Merge v1.89.0 into Develop

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@siddhartha-quad siddhartha-quad requested a review from a team as a code owner April 30, 2026 05:01
@siddhartha-quad siddhartha-quad added the release-chore To not include into release notes label Apr 30, 2026
@github-actions github-actions Bot added the external PR from external contributor label Apr 30, 2026
@gemini-code-assist

gemini-code-assist Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine version update for the HPC Toolkit, incrementing the version from v1.88.0 to v1.89.0. This change is propagated across all relevant Terraform module metadata files and internal Go source code that references the toolkit's current version, ensuring consistency throughout the project.

Highlights

  • Version Bump: The pull request updates the HPC Toolkit version from v1.88.0 to v1.89.0 across various Terraform module versions.tf files.
  • Internal Configuration Update: The latestToolkitVersion constant in the Go configuration file (pkg/config/config.go) has been updated to reflect the new version.
  • Tooling Metadata Adjustment: The example version string used in the cache_metadata tool's command-line flag description (tools/cache_metadata/main.go) has been updated to v1.89.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 30, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the HPC Toolkit version from v1.88.0 to v1.89.0 across numerous Terraform modules in both the core and community directories, as well as in the Go configuration and metadata caching tools. I have no feedback to provide as the changes are consistent and follow the expected versioning update pattern.

@siddhartha-quad siddhartha-quad merged commit 271777d into develop Apr 30, 2026
23 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LAVEEN LAVEEN LAVEEN approved these changes

@Neelabh94 Neelabh94 Neelabh94 approved these changes

@parulbajaj01 parulbajaj01 parulbajaj01 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@siddhartha-quad @LAVEEN @Neelabh94 @parulbajaj01