adding new workload_identity_binding module.#5574
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a new infrastructure-as-code module designed to streamline the configuration of Workload Identity bindings. By automating the association between Google Service Accounts and Kubernetes Service Accounts, it simplifies the process of granting fine-grained access to GCP resources from within GKE workloads. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Terraform module for managing Workload Identity bindings between Google Service Accounts and Kubernetes Service Accounts. The feedback suggests refactoring the IAM member resource for better consistency and robustness, generalizing the default namespace variable, and relaxing the Terraform version constraint to avoid potential conflicts in larger deployments. Additionally, the module must be registered in the central modules index to comply with the repository style guide.
adding new module workload_identity_binding.
adding new module workload_identity_binding.
Adding a new module to create a Workload Identity binding between a Google Service Account (GSA) and a Kubernetes Service Account (KSA). It manages the service account IAM member role roles/iam.workloadIdentityUser with full project number pathing.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.