Skip to content

adding new redis module.#5569

Merged
arpit974 merged 3 commits into
GoogleCloudPlatform:developfrom
arpit974:redis-module
May 15, 2026
Merged

adding new redis module.#5569
arpit974 merged 3 commits into
GoogleCloudPlatform:developfrom
arpit974:redis-module

Conversation

@arpit974

@arpit974 arpit974 commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Adding a new module to provision a Google Cloud Memorystore for Redis instance. The module supports basic tier, custom memory size, region, Redis version, authentication, connect mode, and authorization on a network. It also handles enabling the Redis API.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

gemini-code-assist Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a new infrastructure module to the toolkit, enabling users to easily deploy and manage Google Cloud Memorystore for Redis instances. The module is designed to be flexible, allowing for custom network and authentication settings, while ensuring the necessary cloud services are enabled.

Highlights

  • New Redis Module: Introduced a new Terraform module to provision Google Cloud Memorystore for Redis instances.
  • Configurability: The module supports various configurations including region, memory size, authentication, and network connectivity.
  • API Management: Included logic to automatically enable the Redis API during deployment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@arpit974 arpit974 added the release-new-modules Added to release notes under the "New Modules" heading. label Apr 29, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 29, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Google Cloud Memorystore for Redis module. The feedback focuses on aligning the module with Cluster Toolkit standards, specifically by parameterizing hardcoded values such as tier and memory size, adopting standard naming conventions for variables to support automatic inference, and relaxing the Terraform version constraint to improve module reusability.

Comment thread modules/database/redis/main.tf Outdated
Comment thread modules/database/redis/variables.tf
Comment thread modules/database/redis/README.md Outdated
Comment thread modules/database/redis/versions.tf
@arpit974 arpit974 marked this pull request as ready for review April 29, 2026 06:33
@arpit974 arpit974 requested a review from a team as a code owner April 29, 2026 06:33
Neelabh94
Neelabh94 reviewed Apr 29, 2026
View reviewed changes

@Neelabh94 Neelabh94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few nit comments, PTAL.

Comment thread modules/database/redis/variables.tf
Comment thread modules/database/redis/variables.tf
Comment thread modules/database/redis/outputs.tf
Comment thread modules/database/redis/variables.tf
kvenkatachala333
kvenkatachala333 reviewed Apr 30, 2026
View reviewed changes
Comment thread modules/database/redis/main.tf Outdated
kvenkatachala333
kvenkatachala333 reviewed May 10, 2026
View reviewed changes
Comment thread modules/database/redis/variables.tf
@arpit974 arpit974 merged commit 62442cd into GoogleCloudPlatform:develop May 15, 2026
13 of 79 checks passed
Thibaut-Nurit pushed a commit to Thibaut-Nurit/cluster-toolkit that referenced this pull request May 20, 2026
@arpit974 @Thibaut-Nurit
adding new redis module. (GoogleCloudPlatform#5569)
4e72cf7 
adding new module redis.
kadupoornima pushed a commit to kadupoornima/cluster-toolkit that referenced this pull request May 25, 2026
@arpit974 @kadupoornima
adding new redis module. (GoogleCloudPlatform#5569)
f94d6db 
adding new module redis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neelabh94 Neelabh94 Neelabh94 left review comments

@kvenkatachala333 kvenkatachala333 kvenkatachala333 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-new-modules Added to release notes under the "New Modules" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arpit974 @Neelabh94 @kvenkatachala333