Skip to content

adding new dns-managed-zone module.#5485

Merged
arpit974 merged 5 commits into
GoogleCloudPlatform:developfrom
arpit974:dns-managed-zone-module
May 15, 2026
Merged

adding new dns-managed-zone module.#5485
arpit974 merged 5 commits into
GoogleCloudPlatform:developfrom
arpit974:dns-managed-zone-module

Conversation

@arpit974

@arpit974 arpit974 commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

adding a new module to manage Cloud DNS zones and recordsets.

This module provisions a Cloud DNS Managed Zone and supports the bulk creation of DNS recordsets. It includes automated labeling for cost tracking consistent with Cluster Toolkit standards.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

gemini-code-assist Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a new reusable Terraform module designed to simplify the deployment and management of Google Cloud DNS Managed Zones within the Cluster Toolkit. It provides a structured way to define zones, apply labels, and manage associated DNS record sets.

Highlights

  • New Module Addition: Introduced a new Terraform module 'dns-managed-zone' to manage Google Cloud DNS Managed Zones.
  • Resource Configuration: The module includes support for creating DNS managed zones, configuring record sets, and enabling the necessary DNS API.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 13, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new dns-managed-zone module for creating Google Cloud DNS Managed Zones and record sets. Feedback includes a requirement to index the new module in the root modules/README.md and remove redundant manual documentation. Technical issues were identified regarding an incorrect escaped interpolation in a for_each loop, the need for fully qualified domain names in record sets, and an overly restrictive Terraform version constraint.

Comment thread modules/network/dns-managed-zone/README.md Outdated
Comment thread modules/network/dns-managed-zone/main.tf Outdated
Comment thread modules/network/dns-managed-zone/README.md Outdated
Comment thread modules/network/dns-managed-zone/main.tf Outdated
Comment thread modules/network/dns-managed-zone/versions.tf
@arpit974 arpit974 marked this pull request as ready for review April 29, 2026 04:52
@arpit974 arpit974 requested a review from a team as a code owner April 29, 2026 04:52
@arpit974 arpit974 added the release-new-modules Added to release notes under the "New Modules" heading. label Apr 29, 2026
kvenkatachala333
kvenkatachala333 reviewed Apr 29, 2026
View reviewed changes
Comment thread modules/network/dns-managed-zone/README.md
kvenkatachala333
kvenkatachala333 reviewed May 10, 2026
View reviewed changes
Comment thread modules/network/dns-managed-zone/main.tf Outdated
kvenkatachala333
kvenkatachala333 reviewed May 10, 2026
View reviewed changes
Comment thread modules/network/dns-managed-zone/main.tf Outdated
@arpit974 arpit974 merged commit 8d80704 into GoogleCloudPlatform:develop May 15, 2026
13 of 79 checks passed
Thibaut-Nurit pushed a commit to Thibaut-Nurit/cluster-toolkit that referenced this pull request May 20, 2026
@arpit974 @Thibaut-Nurit
adding new dns-managed-zone module. (GoogleCloudPlatform#5485)
acb26ce 
adding new dns-managed-zone module.
kadupoornima pushed a commit to kadupoornima/cluster-toolkit that referenced this pull request May 25, 2026
@arpit974 @kadupoornima
adding new dns-managed-zone module. (GoogleCloudPlatform#5485)
9c67ab3 
adding new dns-managed-zone module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvenkatachala333 kvenkatachala333 kvenkatachala333 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-new-modules Added to release notes under the "New Modules" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arpit974 @kvenkatachala333