feat: optional infra setup for inference gateway#5453
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enables users to opt into creating the necessary infrastructure for an inference gateway within the GKE A4 deployment. It achieves this by adding a toggleable variable and enhancing the underlying network module to support conditional subnetwork provisioning, ensuring that resources are only created when explicitly requested. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to conditionally enable subnetworks within the VPC module by adding an enabled attribute to the subnetworks input. It also updates the GKE A4 example to utilize this feature for an inference gateway proxy-only subnet. Feedback was provided to ensure the internal enabled key is stripped from the subnetwork configuration before being passed to underlying modules to prevent potential 'unsupported attribute' errors.
4882773 to
899b6e6
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to conditionally enable subnetworks within the VPC module by adding an optional 'enabled' field to the 'subnetworks' input variable. The logic in 'modules/network/vpc/main.tf' was updated to filter out disabled subnetworks before processing CIDR blocks and resource creation. Additionally, the 'gke-a4' example was updated to include a proxy-only subnet for an inference gateway, which is toggled via a new 'enable_inference_gateway' variable. I have no feedback to provide.
|
/gcbrun |
0bd48fd to
2f14bb1
Compare
|
Note in the latest force push, we only set inference gateway. The subnet stuff is now only comments |
2f14bb1 to
2bad0ed
Compare
|
/gcbrun |
Allow user to opt into creating the infrastructure required for
inference gateway. This includes setting the GKE cluster gateway
setting to standard (already exists) & documenting how to create
creating a proxy-only subnet of the used network (new in this PR).
Tested by:
* (1) not specifying anything in gke-a4-deployment.yaml and seeing
the usual default behavior of gateway enabled.
* (2) specifying enable_inference_gateway=true in
gke-a4-deployment.yaml and seeing gateway setting enabled.
2bad0ed to
b287dd5
Compare
|
/gcbrun |
a5eaebf
into
GoogleCloudPlatform:develop
Allow user to opt into creating the infrastructure required for inference gateway. This includes setting the GKE cluster gateway setting to standard (already exists) & creating a proxy-only subnet of the used network (new in this PR).
Tested by:
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.