Skip to content

enable automatic cloud build trigger for OFE path#5428

Merged
Neelabh94 merged 1 commit into
GoogleCloudPlatform:developfrom
aslam-quad:ofe-cloudbuild-trigger-update
Apr 1, 2026
Merged

enable automatic cloud build trigger for OFE path#5428
Neelabh94 merged 1 commit into
GoogleCloudPlatform:developfrom
aslam-quad:ofe-cloudbuild-trigger-update

Conversation

@aslam-quad

@aslam-quad aslam-quad commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR updates the Cloud Build trigger configuration for (PR-OFE-test) tests.

Changes
Removed manual approval (approval_required = true)
Enabled automatic trigger execution
Added path-based filtering:
community/front-end/ofe/**
Ensures trigger runs only when OFE-related changes occur

Behavior
Internal contributors → trigger runs automatically
External contributors → trigger runs via gcbrun comment
No manual approval required after trigger

This helps Dependabot PRs run required tests automatically, so no manual trigger is needed.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@aslam-quad aslam-quad requested review from a team and samskillman as code owners March 30, 2026 09:45
@gemini-code-assist

gemini-code-assist Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Cloud Build trigger configuration for OFE tests to streamline the CI process. By removing the manual approval requirement and restricting the trigger to specific file paths, the build pipeline becomes more efficient and targeted for relevant changes.

Highlights

  • Trigger Configuration: Removed the manual approval requirement for the OFE test cloud build trigger.
  • Path Filtering: Added an included_files filter to ensure the trigger only activates when changes occur within the community/front-end/ofe/ directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions github-actions Bot added the external PR from external contributor label Mar 30, 2026
@aslam-quad aslam-quad marked this pull request as draft March 30, 2026 09:46
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 30, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the manual approval requirement for the OFE test Cloud Build trigger and adds a file path filter to limit triggers to changes in the community/front-end/ofe/ directory. A syntax error was identified in the Terraform file where a descriptive line was added without a comment prefix, which will prevent the configuration from being parsed correctly.

Comment thread tools/cloud-build/provision/pr-ofe-test.tf Outdated
@aslam-quad aslam-quad force-pushed the ofe-cloudbuild-trigger-update branch 2 times, most recently from 9c8f6a2 to 119bdee Compare March 30, 2026 10:14
@aslam-quad aslam-quad added the release-chore To not include into release notes label Mar 30, 2026
@aslam-quad aslam-quad requested a review from Neelabh94 March 30, 2026 10:32
@aslam-quad aslam-quad force-pushed the ofe-cloudbuild-trigger-update branch from 119bdee to 7251c1c Compare March 31, 2026 05:58
@aslam-quad aslam-quad marked this pull request as ready for review March 31, 2026 06:35
@Neelabh94 Neelabh94 enabled auto-merge (squash) April 1, 2026 10:59
@Neelabh94 Neelabh94 merged commit 62b7aad into GoogleCloudPlatform:develop Apr 1, 2026
14 of 73 checks passed
simrankaurb pushed a commit to simrankaurb/cluster-toolkit that referenced this pull request Apr 7, 2026
@aslam-quad @simrankaurb
enable automatic cloud build trigger for OFE path (GoogleCloudPlatfor…
799a7bd 
…m#5428)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neelabh94 Neelabh94 Neelabh94 approved these changes

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aslam-quad @Neelabh94 @SwarnaBharathiMantena