refactor: Introduce internal semver compare module by jamOne- · Pull Request #5411 · GoogleCloudPlatform/cluster-toolkit

jamOne- · 2026-03-26T11:38:12Z

Description

Introduce internal semver compare module to make version checks more readable and maintainable. We'll need it for super-slicing in at least two places: enable_slice_controller gke version check and then later for checking the Kueue version.

This change also changes the required gke version of enable_slice_controller to a more specific version than just 1.35.

Tests

Tested manually.

…loudPlatform#5375)

…latform#5375)

gemini-code-assist · 2026-03-26T11:38:36Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a dedicated internal module for robust semantic version comparison within Terraform configurations. This refactoring aims to centralize and standardize version validation logic, making it more readable and easier to maintain across various features. The initial application of this module is to enhance the GKE version check for the slice controller, with plans for future use in other areas like Kueue version checks.

Highlights

New Semantic Version Comparison Module: An internal Terraform module, semver_compare, has been introduced to provide a standardized and maintainable way to compare semantic versions (major.minor.patch) including optional GKE build numbers. This module includes a 'fail-open' validation logic, ensuring that non-standard version strings (like branch names or commit SHAs) do not inadvertently block advanced users.
Refactored GKE Version Check: The existing GKE version check for the enable_slice_controller feature has been refactored to utilize the new semver_compare module, improving readability and maintainability. This change replaces a manual string parsing and comparison with a dedicated module.
Updated GKE Version Requirement: The minimum required GKE version for the enable_slice_controller has been updated from a general 1.35 to a more specific 1.35.0-gke.274500.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new internal Terraform module, semver_compare, designed to securely perform semantic version comparisons, including an optional GKE build number. This module replaces a manual version check in modules/scheduler/gke-cluster/main.tf for the GKE Slice Controller, ensuring the GKE version meets a minimum requirement. Feedback indicates that the new semver_compare module needs to be added to the modules/README.md index as per the repository's style guide. Additionally, the parsing logic for patch and GKE version components within the semver_compare module's main.tf can be simplified for improved readability and maintainability by removing redundant try() calls.

SwarnaBharathiMantena

Please include license in all the files (reference: https://github.com/GoogleCloudPlatform/cluster-toolkit/tree/main/modules/internal/tpu-definition)
Please include these lines in the README.md of the new module to auto-generate the inputs, outputs, versions info, etc.

<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

SwarnaBharathiMantena · 2026-03-28T14:25:39Z

/gcbrun

SwarnaBharathiMantena · 2026-03-30T06:03:39Z

/gcbrun

SwarnaBharathiMantena · 2026-03-30T09:53:37Z

/gcbrun

jamOne- · 2026-03-30T10:43:54Z

@SwarnaBharathiMantena please re run the tests once again

SwarnaBharathiMantena · 2026-03-30T17:51:45Z

/gcbrun

SwarnaBharathiMantena · 2026-03-31T08:58:29Z

/gcbrun

SwarnaBharathiMantena · 2026-04-01T01:19:08Z

/gcbrun

SwarnaBharathiMantena

LGTM!

…rm#5411)

jamOne- added 3 commits March 26, 2026 11:41

feat: Introduce fail-open semantic version comparison module (GoogleC…

70131fa

…loudPlatform#5375)

feat: extend semver logic to support GKE build versions (GoogleCloudP…

52e4faf

…latform#5375)

docs: update semver_compare README to reflect GKE build suffix logic

8611890

github-actions Bot added the external PR from external contributor label Mar 26, 2026

gemini-code-assist Bot reviewed Mar 26, 2026

View reviewed changes

Comment thread modules/internal/semver_compare/README.md

Comment thread modules/internal/semver_compare/main.tf Outdated

Comment thread modules/internal/semver_compare/main.tf Outdated

jamOne- added 4 commits March 26, 2026 13:37

fix: correct fail-open edge cases and validation on min_version

8238d98

refactor: simplify semver integer parsing with coalesce logic

0195fb0

feat: allow standalone major versions by making minor segment optional

07521af

Merge branch 'develop' into semver-compare

92b200b

jamOne- marked this pull request as ready for review March 26, 2026 13:13

jamOne- requested review from a team and samskillman as code owners March 26, 2026 13:13

Neelabh94 added release-new-modules Added to release notes under the "New Modules" heading. labels Mar 26, 2026

jamOne- marked this pull request as draft March 26, 2026 17:02

SwarnaBharathiMantena requested changes Mar 27, 2026

View reviewed changes

Fix pre-commit errors

26427f6

jamOne- force-pushed the semver-compare branch 2 times, most recently from e1877b1 to 8c83c7c Compare March 27, 2026 16:03

jamOne- marked this pull request as ready for review March 27, 2026 16:03

jamOne- requested a review from SwarnaBharathiMantena March 27, 2026 16:03

SwarnaBharathiMantena added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Mar 28, 2026

jamOne- marked this pull request as draft March 30, 2026 08:17

Merge develop into semver-compare

ca6c6bc

jamOne- force-pushed the semver-compare branch from 8c83c7c to ca6c6bc Compare March 30, 2026 09:28

jamOne- marked this pull request as ready for review March 30, 2026 09:52

Fix null current_version in semver_compare

88fd89d

jamOne- force-pushed the semver-compare branch from a896f34 to 88fd89d Compare March 30, 2026 10:43

Merge origin/develop into semver-compare

91834ca

Merge origin/develop into semver-compare

1962e80

SwarnaBharathiMantena approved these changes Apr 1, 2026

View reviewed changes

SwarnaBharathiMantena enabled auto-merge (squash) April 1, 2026 10:54

kvenkatachala333 approved these changes Apr 1, 2026

View reviewed changes

auto-merge was automatically disabled April 1, 2026 10:55
Repository rule violations found

SwarnaBharathiMantena merged commit 908e7f9 into GoogleCloudPlatform:develop Apr 1, 2026
31 of 71 checks passed

simrankaurb pushed a commit to simrankaurb/cluster-toolkit that referenced this pull request Apr 7, 2026

refactor: Introduce internal semver compare module (GoogleCloudPlatfo…

6be3f15

…rm#5411)

SwarnaBharathiMantena mentioned this pull request Apr 22, 2026

Add DRANET support in Cluster Toolkit #5418

Merged

Conversation

jamOne- commented Mar 26, 2026

Description

Tests

Uh oh!

gemini-code-assist Bot commented Mar 26, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SwarnaBharathiMantena left a comment

Choose a reason for hiding this comment

Uh oh!

SwarnaBharathiMantena commented Mar 28, 2026

Uh oh!

SwarnaBharathiMantena commented Mar 30, 2026

Uh oh!

SwarnaBharathiMantena commented Mar 30, 2026

Uh oh!

jamOne- commented Mar 30, 2026

Uh oh!

SwarnaBharathiMantena commented Mar 30, 2026

Uh oh!

SwarnaBharathiMantena commented Mar 31, 2026

Uh oh!

SwarnaBharathiMantena commented Apr 1, 2026

Uh oh!

SwarnaBharathiMantena left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants