Skip to content

Migrating install_asapd_lite module to helm#5410

Merged
agrawalkhushi18 merged 6 commits into
GoogleCloudPlatform:developfrom
agrawalkhushi18:aspad_lite
Apr 3, 2026
Merged

Migrating install_asapd_lite module to helm#5410
agrawalkhushi18 merged 6 commits into
GoogleCloudPlatform:developfrom
agrawalkhushi18:aspad_lite

Conversation

@agrawalkhushi18

@agrawalkhushi18 agrawalkhushi18 commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR migrates the install_aspad_lite module to use helm provider instead of gavinbunney/kubectl provider as an effort to deprecate the kubectl submodule usage across kubectl-apply.

  • main.tf: Migrated install_asapd_lite module from kubectl provider to helm_install provider, added template variable support for dynamic config rendering, and updated manifest handling logic.
  • variables.tf: Updatedasapd_lite variable schema to support optional parameters with defaults and added config_template_vars for templating support.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@agrawalkhushi18 agrawalkhushi18 added the release-improvements Added to release notes under the "Improvements" heading. label Mar 26, 2026
@gemini-code-assist

gemini-code-assist Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the install_asapd_lite module within the kubectl-apply management module. The core change involves transitioning its deployment mechanism from direct kubectl application to a Helm-based approach. This move streamlines the deployment process for asapd-lite and provides greater configurability through templating options, contributing to a broader initiative to standardize deployments using Helm.

Highlights

  • Migration to Helm: The install_asapd_lite module has been migrated from using the gavinbunney/kubectl provider to the helm_install provider, aligning with the effort to deprecate kubectl submodule usage.
  • Configuration Flexibility: The asapd_lite input variable now supports optional fields for install and config_path, and introduces config_template_vars to allow for templating of configuration files, enhancing flexibility.
  • README Documentation Update: The README.md has been updated to reflect the change in the install_asapd_lite module's source from ./kubectl to ./helm_install and the revised input variable structure.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 26, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the installation of the asapd_lite daemonset by migrating its deployment from a direct kubectl module to a helm_install module. This change involves updating the asapd_lite variable definition in variables.tf and README.md to include optional parameters for installation, configuration path, and template variables. A new local variable asapd_lite_config_content is introduced in main.tf to process the configuration, which is then passed to the helm_install module. A review comment suggests simplifying a conditional check for var.asapd_lite.config_path in main.tf by removing the redundant != null check, as the variable's definition ensures it will default to an empty string.

Comment thread modules/management/kubectl-apply/main.tf
@agrawalkhushi18 agrawalkhushi18 changed the title Migrating install_aspad_lite module to helm Migrating install_asapd_lite module to helm Mar 31, 2026
@agrawalkhushi18 agrawalkhushi18 added the release-breaking-changes Prevents "smooth" re-deploy across versions label Mar 31, 2026
@agrawalkhushi18 agrawalkhushi18 marked this pull request as ready for review March 31, 2026 17:35
@agrawalkhushi18 agrawalkhushi18 requested review from a team and samskillman as code owners March 31, 2026 17:35
@agrawalkhushi18

agrawalkhushi18 commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

/gcbrun(fe3af61)

@agrawalkhushi18

agrawalkhushi18 commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

The changes have been tested locally. The above failing PR tests have been disabled since there is no active reservation for them. The spot tests are successful for the same machine types.

SwarnaBharathiMantena
SwarnaBharathiMantena previously approved these changes Apr 3, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shubpal07
shubpal07 reviewed Apr 3, 2026
View reviewed changes
Comment thread modules/management/kubectl-apply/main.tf
shubpal07
shubpal07 previously approved these changes Apr 3, 2026
View reviewed changes

@shubpal07 shubpal07 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Added minor nits

vikramvs-gg
vikramvs-gg reviewed Apr 3, 2026
View reviewed changes
Comment thread modules/management/kubectl-apply/main.tf Outdated
@agrawalkhushi18 agrawalkhushi18 merged commit 3f13ee7 into GoogleCloudPlatform:develop Apr 3, 2026
16 of 80 checks passed
simrankaurb pushed a commit to simrankaurb/cluster-toolkit that referenced this pull request Apr 7, 2026
@agrawalkhushi18 @simrankaurb
Migrating install_asapd_lite module to helm (GoogleCloudPlatform#5410)
ba813db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramvs-gg vikramvs-gg vikramvs-gg approved these changes

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena left review comments

@shubpal07 shubpal07 shubpal07 left review comments

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-breaking-changes Prevents "smooth" re-deploy across versions release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agrawalkhushi18 @SwarnaBharathiMantena @vikramvs-gg @shubpal07