Skip to content

Support vGPU (fractional GPU) for G4 GKE#5399

Merged
kadupoornima merged 2 commits into
GoogleCloudPlatform:developfrom
kadupoornima:vgpu
Mar 25, 2026
Merged

Support vGPU (fractional GPU) for G4 GKE#5399
kadupoornima merged 2 commits into
GoogleCloudPlatform:developfrom
kadupoornima:vgpu

Conversation

@kadupoornima

@kadupoornima kadupoornima commented Mar 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Added support for G4 vGPU (fractional GPU) in GKE.

Changes:

  • vGPU Support: Added support for vGPU (fractional GPU) for G4 instances in GKE.
  • GKE Version Update: Updated the G4 GKE cluster configuration to a newer version (1.35.2-gke.1485000) and RAPID release channel to accommodate vGPU features.
  • GPU Definition Expansion: Extended the internal GPU definitions to include fractional G4 standard machine types (g4-standard-6, g4-standard-12, g4-standard-24).
  • Documentation Update: Updated the README.md to reflect the new minimum GKE version required for G4 vGPU support.

Testing:

  • This change has been tested locally.
  • Cluster and node pool were deployed successfully.
  • nvidia-smi job run was successfully completed.

@kadupoornima kadupoornima added release-key-new-features Added to release notes under the "Key New Features" heading. release-improvements Added to release notes under the "Improvements" heading. labels Mar 25, 2026
@gemini-code-assist

gemini-code-assist Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for fractional GPUs (vGPU) on G4 virtual machines within Google Kubernetes Engine. The changes involve updating the GKE cluster's version and release channel in the provided example, expanding the internal GPU definitions to recognize new G4 machine types, and updating documentation to inform users of the necessary GKE version for vGPU functionality. This enhancement allows for more flexible and efficient utilization of GPU resources in GKE environments.

Highlights

  • vGPU Support: Added support for vGPU (fractional GPU) for G4 instances in GKE.
  • GKE Version Update: Updated the GKE cluster configuration in the example to a newer version (1.35.2-gke.1485000) and RAPID release channel to accommodate vGPU features.
  • GPU Definition Expansion: Extended the internal GPU definitions to include new G4 standard machine types (g4-standard-6, g4-standard-12, g4-standard-24) for vGPU.
  • Documentation Update: Updated the README.md to reflect the new minimum GKE version required for G4 vGPU support.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 25, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GKE G4 example to support G4 vGPU, requiring GKE version 1.35.2-gke.1485000 and changing the release channel to RAPID. It also adds new g4-standard machine types to the GPU definitions. Feedback suggests using min_master_version for specific GKE versions in the example blueprint for clarity and defining the repeated GPU type string as a local variable in the Terraform module for better maintainability.

Comment thread examples/gke-g4/gke-g4.yaml
Comment thread modules/internal/gpu-definition/main.tf
@kadupoornima kadupoornima marked this pull request as ready for review March 25, 2026 09:51
@kadupoornima kadupoornima requested review from a team and samskillman as code owners March 25, 2026 09:51
@kadupoornima kadupoornima enabled auto-merge (squash) March 25, 2026 09:51
@kadupoornima kadupoornima merged commit 2056cc5 into GoogleCloudPlatform:develop Mar 25, 2026
72 of 76 checks passed
FIoannides pushed a commit to FIoannides/cluster-toolkit that referenced this pull request Mar 27, 2026
@kadupoornima @FIoannides
Support vGPU (fractional GPU) for G4 GKE (GoogleCloudPlatform#5399)
7ee3e3f
@kadupoornima kadupoornima deleted the vgpu branch March 30, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gokamesh gokamesh gokamesh approved these changes

@SwarnaBharathiMantena SwarnaBharathiMantena Awaiting requested review from SwarnaBharathiMantena

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading. release-key-new-features Added to release notes under the "Key New Features" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kadupoornima @gokamesh